Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Roll pinned stable toolchain #705

Conversation

google-pr-creation-bot
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@joshlf
Copy link
Member

joshlf commented Dec 9, 2023

My best guess as to what happened here: The way the auto-roller works is that it updates Cargo.toml to the latest stable version, re-generates the UI test .stderr files, and then sees if there's a git diff. Normally, there's only a git diff if there's a new stable toolchain version available. This is because the tests should be deterministic. However, as described in #706 (comment), we must be failing to run some UI tests, and so bad UI test .stderr files got committed. When this auto-roller ran, despite there not being any new stable version, some .stderr files were still updated, and so a git diff was detected, and so this PR was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants