Use KnownLayout to construct and operate on Refs #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `Ref::new_known_layout_name_to_be_bikeshedded`. This is a private constructor which takes a `T: ?Sized + KnownLayout` bound. Before we make `KnownLayout` public, we will make it public and settle on a final name. Also add the ability to dereference a `Ref`, requiring the caller to promise bit validity. Refactor `TryFromBytes::try_from_ref` to use this instead of calling `Ptr::as_ref` directly, allowing `try_from_ref`'s internal safety comments to be significantly simpler. This machinery can be re-used to add APIs with a `T: ?Sized + KnownLayout + FromBytes` bound which allow for safe dereferencing. Makes progress on #29
34 tasks
jswrenn
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Ref::new_known_layout_name_to_be_bikeshedded. This is a private constructor which takes aT: ?Sized + KnownLayoutbound. Before we makeKnownLayoutpublic, we will make it public and settle on a final name.Also add the ability to dereference a
Ref, requiring the caller to promise bit validity. RefactorTryFromBytes::try_from_refto use this instead of callingPtr::as_refdirectly, allowingtry_from_ref's internal safety comments to be significantly simpler. This machinery can be re-used to add APIs with aT: ?Sized + KnownLayout + FromBytesbound which allow for safe dereferencing.Makes progress on #29