Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TryFromBytes for [T] #666

Merged
merged 1 commit into from Dec 5, 2023
Merged

Implement TryFromBytes for [T] #666

merged 1 commit into from Dec 5, 2023

Conversation

jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Dec 1, 2023

Makes progress on #5.

@jswrenn jswrenn force-pushed the tryfrombytes-for-slice branch 4 times, most recently from 4f19b8c to b0537ea Compare December 4, 2023 18:34
@jswrenn jswrenn changed the title [wip] implement TryFromBytes for [T] Implement TryFromBytes for [T] Dec 4, 2023
@jswrenn jswrenn requested a review from joshlf December 4, 2023 18:35
@jswrenn jswrenn marked this pull request as ready for review December 4, 2023 18:35
src/lib.rs Outdated Show resolved Hide resolved
src/util.rs Outdated Show resolved Hide resolved
src/util.rs Outdated Show resolved Hide resolved
src/util.rs Outdated Show resolved Hide resolved
src/util.rs Outdated Show resolved Hide resolved
// memory referenced by `elem` is contained entirely within `c`, and
// satisfies the preconditions satisfied by `c`. By axiom, we assume
// that `Iterator:all` does not invalidate these preconditions
// (e.g., by writing to `elem`.) Since `elem` is derived from `c`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// (e.g., by writing to `elem`.) Since `elem` is derived from `c`,
// (e.g., by writing to `elem`). Since `elem` is derived from `c`,

@jswrenn jswrenn added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit ac0c27e Dec 5, 2023
126 checks passed
@jswrenn jswrenn deleted the tryfrombytes-for-slice branch December 5, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants