Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Test some targets only in the merge queue #1314

Merged
merged 2 commits into from
May 19, 2024

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented May 19, 2024

Comparing [1] (run with the parent commit) and [2] (run with this commit), we see an overall speedup of 6m54s -> 5m36s, or ~19%. These gains will only be realized during PR development; the CI test execution time in the merge queue will remain unchanged.

Makes progress on #1310

[1] https://github.com/google/zerocopy/actions/runs/9149561660
[2] https://github.com/google/zerocopy/actions/runs/9149620991?pr=1314

Comparing [1] (run with the parent commit) and [2] (run with this
commit), we see an overall speedup of 19m33s -> 6m53s, or ~65%. These
gains will only be realized during PR development; the CI test execution
time in the merge queue will remain unchanged.

[1] https://github.com/google/zerocopy/actions/runs/9149347472
[2] https://github.com/google/zerocopy/actions/runs/9149505999?pr=1313
Comparing [1] (run with the parent commit) and [2] (run with this
commit), we see an overall speedup of 6m54s -> 5m36s, or ~19%. These
gains will only be realized during PR development; the CI test execution
time in the merge queue will remain unchanged.

Makes progress on #1310

[1] https://github.com/google/zerocopy/actions/runs/9149561660
[2] https://github.com/google/zerocopy/actions/runs/9149620991?pr=1314
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.71%. Comparing base (a876c40) to head (c56a192).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           miri-test-merge-only    #1314   +/-   ##
=====================================================
  Coverage                 87.71%   87.71%           
=====================================================
  Files                        15       15           
  Lines                      5138     5138           
=====================================================
  Hits                       4507     4507           
  Misses                      631      631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf force-pushed the ci-targets-merge-queue-only branch from 7c33a64 to c56a192 Compare May 19, 2024 18:22
@joshlf joshlf requested a review from jswrenn May 19, 2024 18:22
@joshlf joshlf marked this pull request as ready for review May 19, 2024 18:22
Base automatically changed from miri-test-merge-only to main May 19, 2024 18:34
@joshlf joshlf added this pull request to the merge queue May 19, 2024
@joshlf joshlf mentioned this pull request May 19, 2024
Merged via the queue into main with commit 134b798 May 19, 2024
56 checks passed
@joshlf joshlf deleted the ci-targets-merge-queue-only branch May 19, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants