Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
this PR for the Vuln Detector Plugin for https://nvd.nist.gov/vuln/detail/CVE-2024-21650 (see #366)
In order to verify the vulnerability, I used two different docker environment types, one for the vulnerable version and the other for the fixed version.
To get them pls clone https://github.com/xwiki/xwiki-docker.git.
There are several versions of XWiki. I did use all of them for testing purpose. "15" folder contains latest one.
I can show you how to prepare it for testing:
To run vulnerable version:
docker-compose --env-file .env-true-positive -p xwiki-true-positive up -d
Fixed version:
docker-compose --env-file .env-true-negative -p xwiki-true-negative up -d