Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new NL2Q API. #3073

Merged
merged 22 commits into from
May 30, 2024
Merged

Create new NL2Q API. #3073

merged 22 commits into from
May 30, 2024

Conversation

dianakramer
Copy link
Contributor

@dianakramer dianakramer commented Apr 17, 2024 •
edited

  • What existing problem does this PR solve?
    Creating queries from natural language questions (following DFIQ).
  • What new feature is being introduced with this PR?
    Natural language to query with DFIQ.
  • Overview of changes to existing functions if required.
    Creating a new API.

#3074

@dianakramer dianakramer marked this pull request as ready for review April 25, 2024 11:21
@jkppr jkppr self-requested a review April 25, 2024 11:22
@jkppr jkppr added the Backend label Apr 25, 2024
jkppr
jkppr requested changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this great feature!

Please take care of the comments below.

Also, please add a test for this API endpoint.

data/llms/data_types.csv Outdated Show resolved Hide resolved
data/timesketch.conf Outdated Show resolved Hide resolved
data/timesketch.conf Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
jkppr
jkppr requested changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of the comments below.

data/timesketch.conf Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources/nl2q.py Outdated Show resolved Hide resolved
timesketch/api/v1/resources_test.py Outdated Show resolved Hide resolved
timesketch/lib/testlib.py Outdated Show resolved Hide resolved
jkppr
jkppr approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkppr jkppr linked an issue May 30, 2024 that may be closed by this pull request
Natural language to query with LLM #3074
Open
@jkppr jkppr removed a link to an issue May 30, 2024
Natural language to query with LLM #3074
Open
@jkppr jkppr merged commit 900cf59 into google:master May 30, 2024
24 checks passed
@jkppr jkppr mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkppr jkppr jkppr approved these changes

Assignees

@dianakramer dianakramer

Labels
Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dianakramer @jkppr