Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvyukov remove ipc info #4819

Merged
merged 4 commits into from
May 21, 2024
Merged

dvyukov remove ipc info #4819

merged 4 commits into from
May 21, 2024

Conversation

dvyukov
Copy link
Collaborator

@dvyukov dvyukov commented May 17, 2024

  • syz-manager
  • pkg/ipc: remove ProgInfo

@dvyukov
Copy link
Collaborator Author

dvyukov commented May 17, 2024

This is on top of #4818.
We can either merge #4818 first and then rebase this, or merge this.

@dvyukov dvyukov force-pushed the dvyukov-remove-ipc-info branch 6 times, most recently from 8fc674c to 1fa5a31 Compare May 17, 2024 17:11
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

Attention: Patch coverage is 22.59036% with 257 lines in your changes are missing coverage. Please review.

Project coverage is 61.2%. Comparing base (98aa8d4) to head (13e876f).
Report is 1 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
pkg/instance/instance.go 10.2% <ø> (ø)
pkg/report/report.go 81.9% <ø> (ø)
syz-fuzzer/fuzzer.go 5.6% <100.0%> (+0.9%) ⬆️
syz-manager/stats.go 0.0% <ø> (ø)
pkg/fuzzer/fuzzer.go 67.8% <91.7%> (-1.0%) ⬇️
pkg/fuzzer/queue/queue.go 39.9% <0.0%> (+0.4%) ⬆️
syz-fuzzer/testing.go 0.0% <0.0%> (ø)
pkg/vminfo/features.go 66.9% <33.3%> (ø)
pkg/runtest/run.go 67.5% <91.2%> (+0.1%) ⬆️
pkg/vminfo/syscalls.go 78.6% <60.0%> (ø)
... and 8 more

... and 9 files with indirect coverage changes

@dvyukov dvyukov force-pushed the dvyukov-remove-ipc-info branch 2 times, most recently from 99ac6f7 to 50e8159 Compare May 21, 2024 07:50
@dvyukov dvyukov requested a review from a-nogikh May 21, 2024 08:17
@dvyukov
pkg/ipc: remove ProgInfo
8264b45 
Switch to flatrpc.ProgInfo.

Note: this disables syz-runtest and syz-verifier.
@dvyukov
pkg/ipc: remove ExecOpts
e5d91b0 
Switch to flatrpc.ExecOpts.
@dvyukov
syz-manager: make num fuzzing stat more precise
6ba6797 
Make num fuzzing VMs stat more precise:
increment when the VM is actually ready to execute test programs,
decrement as soon as we see oops in console output.
Also show it on graphs.
a-nogikh
a-nogikh previously approved these changes May 21, 2024
View reviewed changes
syz-ci/manager.go Outdated Show resolved Hide resolved
@dvyukov
syz-ci: switch to using syz-manager for smoke testing
13e876f 
Add smoke testing mode to manager and use it in syz-ci
instead of pkg/instance which uses syz-fuzzer binary.
@dvyukov dvyukov requested a review from a-nogikh May 21, 2024 09:37
@dvyukov dvyukov enabled auto-merge May 21, 2024 09:39
@dvyukov dvyukov added this pull request to the merge queue May 21, 2024
Merged via the queue into google:master with commit 1014eca May 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-nogikh a-nogikh a-nogikh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvyukov @a-nogikh