Don't run the integration tests on every PR #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration tests can randomly fail because they're operating on live data that can change unexpectedly. This results in tests failing on a PR through no fault of the code in the PR. We already run the integration tests on every *commit*, so it's just a matter of surfacing those failures to the people who can do something about them.
|
Thinking more, would it make sense to still make this run (but have passing be optional?). This can be useful for making sure API changes don't break things before they land. |
Is there a way we can confine it to only run when there are API changes? |
Not sure if there's an easy way, but if it's non blocking it should be a minor issue even if it does run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests can randomly fail because they're operating on live data that can change unexpectedly. This results in tests failing on a PR through no fault of the code in the PR. We already run the integration tests on every commit, so it's just a matter of surfacing those failures to the people who can do something about them.