Issue 1013/reduce website latency/2 #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the github action png with a .webp image. As this image is partially visibile on the mobile screens, we can defer the loading of this image.
Preload the LCP image with a high fetchpriority so it starts loading with the stylesheet.
zahraaalizadeh
requested review from
oliverchang,
another-rex and
ZhangChen199102
zahraaalizadeh
commented
May 21, 2024
| <img src="/static/img/github-action-scan-output.png" alt="Screenshot of OSV-Scanner GitHub Action"> | ||
| <img src="/static/img/github-action-scan-output.webp" alt="Screenshot of OSV-Scanner GitHub Action" loading="lazy"> |
There was a problem hiding this comment.
Before:
After:
Comment on lines
4
to
8
| {% block extra_head %} | ||
| <link rel="preload" fetchpriority="high" as="image" href="/static/img/background-1.webp" type="image/webp"> | ||
| <link rel="preload" fetchpriority="high" as="image" href="/static/img/background-2.webp" type="image/webp"> | ||
| <link rel="preload" fetchpriority="high" as="image" href="/static/img/footer-decoration.webp" type="image/webp"> | ||
| {% endblock %} |
There was a problem hiding this comment.
Before:
After:
Comment on lines
+17
to
+22
| <link rel="preload" href="https://fonts.googleapis.com/css?family=Material+Icons&display=block" as="style" onload="this.onload=null;this.rel='stylesheet'"> | ||
| <link rel="preload" href="https://fonts.googleapis.com/css2?family=Overpass+Mono:wght@400;700&family=Overpass:ital,wght@0,400;0,700;1,400&display=swap" as="style" onload="this.onload=null;this.rel='stylesheet'"> | ||
| <noscript> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Material+Icons&display=block"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Overpass+Mono:wght@400;700&family=Overpass:ital,wght@0,400;0,700;1,400&display=swap"> | ||
| </noscript> |
There was a problem hiding this comment.
Before:
After:
another-rex
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances image handling on the home page for better performance, especially on mobile.