-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create get vulnerability details API #2207
base: master
Are you sure you want to change the base?
Create get vulnerability details API #2207
Conversation
gcp/appengine/frontend_handlers.py
Outdated
@@ -237,102 +237,6 @@ def vulnerability_redirector(potential_vuln_id): | |||
return None | |||
|
|||
|
|||
def bug_to_response(bug, detailed=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving these functions to utils.py
so they can be used by both of api_handlers
and frontend_handlers
.
gcp/appengine/api_handlers.py
Outdated
@@ -0,0 +1,47 @@ | |||
# Copyright 2021 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a new app for API
985d7d8
to
4c2aee4
Compare
4c2aee4
to
3f12c8a
Compare
Unless I'm misunderstanding the goal, rather than putting API code in the frontend as well, I think we can just put a link to the GET API endpoint on the page, or add a new handler to redirect requests ending in .json to the API endpoint. |
That was my understanding of the easiest way forward based on #2152 (comment) |
3f12c8a
to
7a4ff83
Compare
Issue: #2152
This PR introduces a new GET vulnerability details API