Search for existing commits case-insensitively #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also stop looking once one's been found. While eyeballing the cleanup in staging I noticed some records being deleted that were not expected, and it was because they had previous converted when they only had commit references, but then didn't once they had versions and the commit references, due to this case-sensitivity mishandling the situation.
another-rex
approved these changes
May 8, 2024
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
May 10, 2024
Problem: google#2182 made checks for existing commits case-insensitive by repo, but left the underlying repo string alone. There are a lot of mixed-case GitHub repos in existence, because cves.extractGitCommit() takes the repo verbatim. vulns.AddPkgInfo() aggregates events by repo, case insensitively, so was producing incorrect GIT events. GitHub repo names are known to be case insensitive, so this is safe for them. It's definitively less safe for other URLs, so limit to just them for now.
andrewpollock
added a commit
that referenced
this pull request
May 10, 2024
Problem: #2182 made checks for existing commits case-insensitive by repo, but left the underlying repo string alone. There are a lot of mixed-case GitHub repos in existence, because `cves.extractGitCommit()` takes the repo verbatim. `vulns.AddPkgInfo()` aggregates events by repo, case insensitively, so was producing incorrect GIT events. GitHub repo names are known to be case insensitive, so this is safe for them. It's definitively less safe for other URLs, so limit to just them for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also stop looking once one's been found.
While eyeballing the cleanup in staging I noticed some records being deleted that were not expected, and it was because they had previous converted when they only had commit references, but then didn't once they had versions and the commit references, due to this case-sensitivity mishandling the situation.