Configure GCLB in terraform #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkedar
requested review from
oliverchang,
rjerrems,
andrewpollock,
hogo6002,
cuixq and
another-rex
andrewpollock
approved these changes
May 8, 2024
| groups = [ | ||
| { | ||
| # TODO(michaelkedar): Replace with Cloud Run when ready |
There was a problem hiding this comment.
The picture I had in my head was we could have both back ends ~now, with the Cloud Run backend drained of any traffic. Is that possible to do?
There was a problem hiding this comment.
I think I've managed to work out how to do this with c650a4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because importing existing resources is awkward (and will end up deleting/recreating most things if our names don't line up), I've decided to put all the Load Balancer / Certificate stuff into terraform now. I've tried to match what was set up manually on staging as closely as possible. I also added an IPv6 address, since our App Engine currently also has IPv6.
The google-managed certificate stuff is now set up in terraform, but configuring the DNS
CNAME/A/AAAArecords still needs to be done manually. I've added an output to the terraform to display all the records that need to be created.The existing Load Balancer and Certificate stuff needs to be deleted from staging before merging this, and the DNS records need to be updated after.