New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the title to display summary instead of id #2137
Update the title to display summary instead of id #2137
Conversation
Thanks! Could we instead add the summary to the main part of the page, above "details" ? IMO the title should remain the vulnerability ID. |
@oliverchang Sometimes details include a Summary section too. Adding a field like Summary or Brief summary might seem duplicated? WDYT? |
I think that's OK. We should accurately render what's in the source JSON. |
190476b
to
d4bbecd
Compare
@oliverchang I updated it as per suggestion. Now there's a |
It is starting to look a bit busy, can you add a gap between summary and the Modified field above it (similar to the gap between references and details). This way we have 3 mini sections separated with some padding:
Also, for some entries summary is empty, in those cases I think we should just hide the summary field (though that might be confusing, maybe a greyed out |
Prior to this change, if there were no summary provided in the schema json it displayed nothing, which is a bit confusing. This change shows a grayout [none] when the summary is not included in the json.
@another-rex Thanks for your suggestions, I applied them in dc46044 and |
/gcbrun |
It seems not all entries have |
Apologies, that was a poorly formed statement... I meant to say it could be omitted when it is empty/undefined, but that inconsistency could also be visually jarring and may be worse than what we have now. |
Prior to this change, in the vulnerability page, id of the vulnerability was displayed as title.
This change updates the title to display the human readable summary for the title, and adds ID as an data description.
resolves #2078
example 1 - Before:
After:
Example 2 - Before:
After: