Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove "verbose" verbosity level #1686

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 2, 2025

We're only actually using this level in one place currently, and it is not one of the log levels defined by slog by default - I also think there's an argument to be made that "verbose" itself is something of a mode rather than a level; i.e. it implies maybe all logs should be shown regardless of their level, or debug, or some other combination.

Either way I think we should remove it as part of v2 while we can to make things a bit simpler and we can introduce it back in a minor version if/when we decide to use it.

@G-Rath G-Rath requested review from another-rex, cuixq and hogo6002 March 2, 2025 20:48
@G-Rath G-Rath force-pushed the output/remove-verbose branch from 75ee16c to 199d4dd Compare March 2, 2025 21:09
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.57%. Comparing base (caaabe2) to head (d2315bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   64.60%   64.57%   -0.04%     
==========================================
  Files         156      156              
  Lines       16014    15980      -34     
==========================================
- Hits        10346    10319      -27     
+ Misses       4986     4979       -7     
  Partials      682      682              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath force-pushed the output/remove-verbose branch from 199d4dd to d2315bc Compare March 2, 2025 23:46
@another-rex another-rex merged commit 583531a into google:main Mar 3, 2025
13 checks passed
@another-rex another-rex deleted the output/remove-verbose branch March 3, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants