Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make non-interactive the default mode of guided remediation #1670

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Feb 26, 2025

This PR makes non-interactive the default mode for guided remediation:

  • adds --interactive flag for the interactive mode;
  • deprecates --non-interactive flag;
  • updates tests and docs accordingly.

Also moves guided remediation from experimental.

@cuixq cuixq marked this pull request as ready for review February 26, 2025 05:30
@cuixq cuixq requested a review from michaelkedar February 26, 2025 05:30
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (583531a) to head (c7a2b75).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
cmd/osv-scanner/fix/main.go 25.00% 5 Missing and 1 partial ⚠️
cmd/osv-scanner/fix/interactive.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1670      +/-   ##
==========================================
- Coverage   64.57%   64.57%   -0.01%     
==========================================
  Files         156      156              
  Lines       15980    15981       +1     
==========================================
  Hits        10319    10319              
- Misses       4979     4981       +2     
+ Partials      682      681       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cuixq and others added 2 commits March 3, 2025 13:53
@cuixq cuixq merged commit 8a7e9d9 into google:main Mar 3, 2025
13 checks passed
@cuixq cuixq deleted the interactive branch March 3, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants