Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge experimental-licenses-summary and experimental-licenses into one generic flag #1651

Merged
merged 9 commits into from
Feb 25, 2025

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Feb 20, 2025

Partially resolves #1644

This PR merges experimental-licenses-summary and experimental-licenses into one generic flag:
--experimental-licenses: only shows the summary
--experimental-licenses=[allowlist]: shows both the summary and the packages with violations

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 85.12397% with 18 lines in your changes missing coverage. Please review.

Project coverage is 64.61%. Comparing base (91f56a9) to head (e2ecb13).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/osvscanner/osvscanner.go 78.57% 6 Missing and 3 partials ⚠️
cmd/osv-scanner/internal/helper/helper.go 81.81% 4 Missing and 2 partials ⚠️
internal/output/table.go 90.90% 1 Missing and 1 partial ⚠️
pkg/reporter/vertical_reporter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
+ Coverage   64.56%   64.61%   +0.04%     
==========================================
  Files         155      155              
  Lines       15997    16003       +6     
==========================================
+ Hits        10329    10340      +11     
+ Misses       4984     4980       -4     
+ Partials      684      683       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hogo6002 hogo6002 marked this pull request as ready for review February 21, 2025 02:10
@hogo6002 hogo6002 requested a review from another-rex February 25, 2025 05:40
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example of just license summary with no vulnerabilities? (With the table output)

@hogo6002 hogo6002 requested a review from another-rex February 25, 2025 06:01
@hogo6002 hogo6002 merged commit b18053a into google:main Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move license scanning out of experimental mode
4 participants