Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove deprecated packages #1638

Merged
merged 15 commits into from
Feb 20, 2025

Conversation

another-rex
Copy link
Collaborator

Removes:

  • models.Vulnerability => Migrated to osvschema
  • models.Ecosystem => Now use a combo of osvschema.Ecosystem, and ecosystem.Parsed
  • models Constants => osvschema.Ecosystem constants
  • lockfile package => Now completely use the migrated extractors in osv-scalibr
  • osv package => Now use osvdev
  • semantic package => Now use the migrated package in osv-scalibr

Had to update various things to make sure things still compiled, most of the changes are a result of moving off of models.Vulnerability.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 84.01826% with 35 lines in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (110ec91) to head (92084fc).

Files with missing lines Patch % Lines
internal/utility/semverlike/version-semver-like.go 35.00% 12 Missing and 1 partial ⚠️
internal/utility/purl/purl_to_package.go 84.21% 4 Missing and 2 partials ⚠️
internal/utility/vulns/vulnerability.go 86.48% 2 Missing and 3 partials ⚠️
internal/utility/purl/purl.go 57.14% 2 Missing and 1 partial ⚠️
internal/clients/clientimpl/localmatcher/zip.go 77.77% 2 Missing ⚠️
internal/tui/severity.go 0.00% 2 Missing ⚠️
internal/utility/depgroup/devgroup.go 85.71% 2 Missing ⚠️
cmd/osv-scanner/fix/main.go 0.00% 1 Missing ⚠️
...al/clients/clientimpl/localmatcher/localmatcher.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
- Coverage   68.74%   64.28%   -4.47%     
==========================================
  Files         200      154      -46     
  Lines       19147    15809    -3338     
==========================================
- Hits        13163    10163    -3000     
+ Misses       5280     4969     -311     
+ Partials      704      677      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

another-rex and others added 5 commits February 19, 2025 13:47
@another-rex another-rex requested a review from cuixq February 19, 2025 04:46
@another-rex another-rex force-pushed the remove-deprecated-pacakges branch from f7230c2 to 92084fc Compare February 20, 2025 00:22
@another-rex another-rex merged commit 958dbe8 into google:main Feb 20, 2025
13 checks passed
another-rex pushed a commit that referenced this pull request Feb 24, 2025
`semantic` package has been removed in
#1638.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants