Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot config file #7431

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Add dependabot config file #7431

merged 1 commit into from
Mar 24, 2022

Conversation

jonathanmetzman
Copy link
Contributor

Related: #7425

@jonathanmetzman
Copy link
Contributor Author

CC @oliverchang

@jonathanmetzman jonathanmetzman merged commit 2e0e330 into master Mar 24, 2022
@jonathanmetzman jonathanmetzman deleted the dependabot branch March 24, 2022 12:47
@evverx
Copy link
Contributor

evverx commented Mar 24, 2022

@jonathanmetzman due to a GitHub bug every fork receives PRs from Dependabot like https://github.com/evverx/oss-fuzz/pulls. It would be great if it was possible to switch from daily updates to weekly (or even monthly) updates to reduce the noise. It's also possible to limit the number of PRs Dependabot can create with open-pull-requests-limit:

@evverx
Copy link
Contributor

evverx commented Mar 24, 2022

In the meantime I unsubscribed from the notifications there and turned off GHActions so as not to clog up my GHActions pool. It seems to be the only way to deal with those PRs unfortunately.

@jonathanmetzman
Copy link
Contributor Author

jonathanmetzman commented Mar 24, 2022

@jonathanmetzman due to a GitHub bug every fork receives PRs from Dependabot like https://github.com/evverx/oss-fuzz/pulls. It would be great if it was possible to switch from daily updates to weekly (or even monthly) updates to reduce the noise. It's also possible to limit the number of PRs Dependabot can create with open-pull-requests-limit:

Oy, really silly of dependabot to do this.
I'm going to get rid of it.

@evverx
Copy link
Contributor

evverx commented Mar 24, 2022

It was reported back in 2019 in dependabot/dependabot-core#2198 and I'm not sure why it hasn't been fixed. Renovatebot is better in this regard in the sense that it has to be enabled explicitly but it has its own issues.

@jonathanmetzman
Copy link
Contributor Author

What are the issues Renovatebot has? Maybe well use it instead.

@jonathanmetzman
Copy link
Contributor Author

I got rid of dependabot btw: #7453

@evverx
Copy link
Contributor

evverx commented Mar 24, 2022

Last time I checked it wasn't human-friendly. For example it just showed commit hashes instead of versions when dependencies were pinned to shas: evverx/systemd#30

@jonathanmetzman
Copy link
Contributor Author

jonathanmetzman commented Mar 24, 2022

:-\

Luckily it looks you might have been the only user hit by this https://github.com/search?q=dependabot+fork%3Aonly+%22bump+google-api-python-client+from+1.9.3+to+2.42.0+in+%2Finfra%2Fbuild%2Ffunctions%22&type=issues

I guess to get the issue you need to:

  1. Have dependabot enabled on your account (?)
  2. Updated after I added dependabot
  3. Updated before I merged all of dependabot's PRs.

@evverx
Copy link
Contributor

evverx commented Mar 24, 2022

Have dependabot enabled on your account

I don't think I have ever enabled Dependabot there. I tried to investigate that in systemd/systemd#21343 but the scenario described there doesn't seem to be the only way to trigger it.

Updated after I added dependabot

Yes it pops up once forks are updated. It can take some time but eventually every fork created before Dependabot is introduced seems to be hit by it. The latest example would be ssahani/systemd#9 (comment) where I was asked what was that.

MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants