Added createJsonKeys #1401
Added createJsonKeys #1401
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
looks like you're missing a dependency override in json_serializable |
|
@ChreSyr – I landed some fixes – take a look! |
| @@ -1,6 +1,8 @@ | |||
| ## 4.8.2-wip | |||
|
|
|||
| - Require Dart 3.0 | |||
| - Added `JsonSerializable(createJsonKeys: true)`. | |||
There was a problem hiding this comment.
This should be 4.9.0 since we're adding new features!
There was a problem hiding this comment.
Ditto with json_serial. I'll do it. Just FYI for future.
| } | ||
|
|
||
| typedef ModelJsonKeys = _$ModelJsonKeys; |
There was a problem hiding this comment.
Smart, i like the idea
There was a problem hiding this comment.
@ChreSyr would be really nice to have this auto generated inside json_keys_example.g.dart above the generated ModelJsonKeys class
|
Thanks @kevmoo for your help and work ! It was my first experience in open-source contribution, I will definitely continue. |
See #1400