Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to targetSdk = 34 #2229

Merged
merged 4 commits into from
May 20, 2024
Merged

Switch to targetSdk = 34 #2229

merged 4 commits into from
May 20, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented May 8, 2024

WHAT

WHY

HOW

Checklist 馃搵

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

yschimke and others added 3 commits May 8, 2024 09:11
@yschimke
Test build with targetSdk = 34
f6b034e
@huewu
Declare required permissions to run FGS on Wear5 (#2231)
c99af2a 
An app must declare a specific permission based on the foreground service type on Wear 5
@yschimke
Merge branch 'main' into target-34
0cea595
@yschimke yschimke marked this pull request as ready for review May 16, 2024 18:56
@yschimke yschimke changed the title Test build with targetSdk = 34 Switch to targetSdk = 34 May 16, 2024
@yschimke
Copy link
Collaborator Author

cc @huewu

@yschimke yschimke requested a review from garanj May 16, 2024 18:59
@yschimke yschimke merged commit 1db80cc into main May 20, 2024
6 checks passed
@yschimke yschimke deleted the target-34 branch May 20, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garanj garanj garanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yschimke @garanj @huewu