[MediaUI] Don't encode null into route when navigating to a media item #1465
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
When selecting a media item with a null collection, the route becomes
mediaItem?id=<id>null
I don't think this is the intended behavior. Instead we should skip the collection argument entirely in that case. Otherwise when parsing the argument you have to deal with the null at the end.
The sample app doesn't seem to call this function. I tried to add a simple unit test here but it doesn't look like there's any test coverage in the file so I think it'd be a lot of setup. Let me know if you want to me try though.
Thanks
Checklist 📋