Roll back [the change that made LocalCache avoid synchronized](https://github.com/google/guava/commit/1512730820a99e329a475b7143b7295775ef26ba).
#6972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_605049501
branch
from
0aa784b
to
141baba
Compare
…12730). The `LocalCache` change led to [false reports of recursion during refresh](#6851 (comment)). This CL keeps the new tests from the `LocalCache` change, which already would have passed before the CL. Ideally we would additionally include [tests that demonstrate the refresh problem](#6851 (comment)), but we'll need to see if the contributor can sign a CLA. This rollback un-fixes #6845. Users of `common.cache` and virtual threads will likely have to wait until `synchronized` no longer pins threads. (And at that point, if not earlier, they should migrate to [Caffeine](https://github.com/ben-manes/caffeine) :)) RELNOTES=`cache`: Fixed a bug that could cause [false "recursive load" reports during refresh](#6851 (comment)). PiperOrigin-RevId: 605069776
copybara-service
bot
force-pushed
the
test_605049501
branch
from
141baba
to
0e1aebf
Compare
copybara-service
bot
closed this pull request by merging all changes
into
master
in
0e1aebf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll back the change that made
LocalCacheavoidsynchronized.The
LocalCachechange led to false reports of recursion during refresh.This CL keeps the new tests from the
LocalCachechange, which already would have passed before the CL. Ideally we would additionally include tests that demonstrate the refresh problem, but we'll need to see if the contributor can sign a CLA.This rollback un-fixes #6845. Users of
common.cacheand virtual threads will likely have to wait untilsynchronizedno longer pins threads. (And at that point, if not earlier, they should migrate to Caffeine :))RELNOTES=
cache: Fixed a bug that could cause false "recursive load" reports during refresh.