Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sdk dep; upgrade to the latest package:lints #408

Merged
merged 6 commits into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/dart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,15 @@ on:
jobs:
build:
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
sdk: ['3.0', stable, beta]
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
- uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
- uses: dart-lang/setup-dart@b64355ae6ca0b5d484f0106a033dd1388965d06d
with:
sdk: ${{ matrix.sdk }}

- name: Install dependencies
run: dart pub get
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.9.5

- Update the SDK constraint to 3.0.
- Rev to the latest version of `package:lints`.

## 0.9.4

- Update the SDK constraint to `>=2.17.0 <4.0.0`.
Expand Down
2 changes: 2 additions & 0 deletions bin/_boot.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
/// The main entry-point (`bin/grinder.dart`) trampolines into a different
/// script; running with `_boot.dart` instead allows you to hit breakpoints when
/// debugging.
library;

import 'package:grinder/grinder.dart';

Future<dynamic> main(List<String> args) => grind(args);
4 changes: 2 additions & 2 deletions lib/grinder_sdk.dart
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ String? _parseVersion(String output) {
}

class _PubGlobalApp extends PubApp {
_PubGlobalApp(String packageName) : super._(packageName);
_PubGlobalApp(super.packageName) : super._();

@override
bool get isGlobal => true;
Expand Down Expand Up @@ -580,7 +580,7 @@ class _PubGlobalApp extends PubApp {
}

class _PubLocalApp extends PubApp {
_PubLocalApp(String packageName) : super._(packageName);
_PubLocalApp(super.packageName) : super._();

@override
bool get isGlobal => false;
Expand Down
2 changes: 1 addition & 1 deletion lib/src/annotations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@ class Depends {
///
/// Use this instead of [Task] when defining the default task.
class DefaultTask extends Task {
const DefaultTask([String? description]) : super(description);
const DefaultTask([super.description]);
}
2 changes: 1 addition & 1 deletion lib/src/cli.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import 'cli_util.dart';
import 'singleton.dart' as singleton;

// This version must be updated in tandem with the pubspec version.
const String appVersion = '0.9.4';
const String appVersion = '0.9.5';

List<String> grinderArgs() {
if (_args == null) fail('grinderArgs() may only be called after grind().');
Expand Down
6 changes: 3 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: grinder
# This version must be updated in tandem with the lib/src/cli.dart version.
version: 0.9.4
version: 0.9.5
description: >-
Grinder is a task runner for Dart, helping to define and automate common
project workflows.
repository: https://github.com/google/grinder.dart

environment:
sdk: '>=2.17.0 <4.0.0'
sdk: ^3.0.0

dependencies:
cli_util: ^0.4.0
Expand All @@ -17,7 +17,7 @@ dependencies:
collection: ^1.15.0

dev_dependencies:
lints: ^2.0.0
lints: ^3.0.0
test: ^1.17.0

executables:
Expand Down
2 changes: 1 addition & 1 deletion tool/grind.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void checkInit() {
final pubspec = temp.join('pubspec.yaml').createFile();
pubspec.writeAsStringSync('''name: foo
environment:
sdk: '>=2.10.0 <3.0.0'
sdk: '^3.0.0'
dependencies:
grinder:
Expand Down