Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom repo roles URL #2702

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

exageraldo
Copy link
Contributor

@exageraldo exageraldo commented Mar 7, 2023

Update the API routes, from /orgs/{org}/custom_roles to /orgs/{org}/custom-repository-roles, and some documentation references.

Fixes: #2700

@exageraldo exageraldo marked this pull request as ready for review March 7, 2023 21:32
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #2702 (91d111e) into master (099fae4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2702   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11442    11457   +15     
=======================================
+ Hits        11219    11234   +15     
  Misses        152      152           
  Partials       71       71           
Impacted Files Coverage Δ
github/orgs_custom_roles.go 94.23% <100.00%> (ø)
github/event.go 100.00% <0.00%> (ø)
github/messages.go 100.00% <0.00%> (ø)
github/event_types.go 100.00% <0.00%> (ø)
github/teams.go 98.18% <0.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 7, 2023

I'm surprised that GitHub did not make a version update for a breaking change like this. I will review this later tonight.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @exageraldo !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 8, 2023
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 8, 2023

LGTM!

Thank you, @valbeat !
Merging.

@gmlewis gmlewis changed the title Change custom repo roles url Update custom repo roles URL Mar 8, 2023
@gmlewis gmlewis merged commit e0bb535 into google:master Mar 8, 2023
exageraldo added a commit to exageraldo/go-github that referenced this pull request Mar 13, 2023
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new Custom Repository Rules API changes
3 participants