Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/gcsblob: Ensure driver sets Content-Type auto-detection properly #3381

Merged

Commits on Mar 1, 2024

  1. blob/gcsblob: Ensure driver sets Content-Type auto-detection properly

    google#3371 made it possible to
    disable Go Cloud's Content-Type auto-detection via the
    `DisableContentTypeDetection` option. However, the Google Cloud
    Storage (GCS) driver still performed auto-detection even if this
    option were enabled, so it was previously not possible to keep
    `Content-Type` blank. This commit adds the
    `DisableContentTypeDetection` option to the the driver and passes
    along the value to make it possible to keep Content-Type blank in the
    GCS object metadata. This enables the use of the
    `Response-Content-Type` override in a signed URL.
    
    This commit needs cloud.google.com/go/storage v1.39
    (googleapis/google-cloud-go#9431).
    stanhu committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    71bf492 View commit details
    Browse the repository at this point in the history