all: prelease #2639
Merged
all: prelease #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
approved these changes
Aug 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
=========================================
- Coverage 66.98% 66.89% -0.1%
=========================================
Files 134 134
Lines 15589 15589
=========================================
- Hits 10443 10428 -15
- Misses 4394 4409 +15
Partials 752 752
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of:
Renamed
prereleasechecks.sh->prerelease.shto match the documentation (commit runtimevar/paramstore: Watch returns same value multiple times #1).Fixed
prerelease.shto skip some packages that havetestdata/but aren't record/replay (it would otherwise fail those packages because it would try to run them with-recordand fail since the flag isn't defined) (commit blob: no way to distinguish non-existent blob #2).Updated all
.replayfiles (commit blob/fileblob: use slash paths instead of filesystem paths for keys #3).Overall, the prerelease went fine except for the hiccups fixed by 1 and 2 above, and #2638, which I will look into separately.