Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incorrect reference link #3167

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Jun 26, 2023

fixed incorrect reference link

@chiamp chiamp self-assigned this Jun 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #3167 (47a6054) into main (01eb19c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3167   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files          54       54           
  Lines        6000     6000           
=======================================
  Hits         4932     4932           
  Misses       1068     1068           

@chiamp chiamp requested review from levskaya and IvyZX June 26, 2023 22:33
Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing this link every time this file's lines changes, can we just link to the py file but not any line?

@chiamp chiamp force-pushed the fix_reference_link branch 2 times, most recently from 2effa8c to 084bef7 Compare June 30, 2023 20:09
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@copybara-service copybara-service bot merged commit 517225e into google:main Jun 30, 2023
19 checks passed
@chiamp chiamp deleted the fix_reference_link branch August 4, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants