[TS] Allows object API to set 0 for a null-default scalar.

[jviel-beta]

Fixes #7863

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[jviel-beta]

I did not include any new test cases.
I haven't looked into your CI, but I believe there's a problem with pathing and dependencies for the TypeScriptTest.py.
TestAll.sh cannot find the script, and the script does not check if esbuild is installed

[dbaileychess]

Is there any generated code that have these changes? You might need to run scripts/generate_code.py to apply them and include them in the PR.

The TypeScriptTest.py seems right: https://github.com/google/flatbuffers/blob/master/tests/ts/TypeScriptTest.py#L25-L28

The TestAll.sh seems broken: https://github.com/google/flatbuffers/blob/master/tests/TestAll.sh#L19 that should have the right path. Not sure if people use this often, but feel free to update in this PR.

[tungmeoo]

ok

[github-actions]

This pull request is stale because it has been open 3 weeks with no activity. Please comment or label not-stale, or this will be closed in 7 days.

[jviel-beta]

not stale

[dbaileychess]

@jviel-beta looks like you need to run the scripts/generate_code.py script and check in the results.

[jviel-beta]

@jviel-beta looks like you need to run the scripts/generate_code.py script and check in the results.

done!
Also updated the path for TypeScriptTests.py in TestAll.sh

[github-actions]

This pull request is stale because it has been open 3 weeks with no activity. Please comment or label not-stale, or this will be closed in 7 days.

[jviel-beta]

not-stale

[jviel-beta]

@dbaileychess or @tungmeoo Can I please get a review on this? It's been sitting for a while now and we'd like to remove the fork. Thanks

[jviel-beta]

@dbaileychess @aardappel. Is anyone available to approve the workflows?

[jviel-beta]

@aardappel Thank you. Looks like the failing tests are not related to my changes... just a clang unused symbol error. Pushed a potential fix.

[jviel-beta]

@aardappel, sorry but I think I need help with the nim failures. Not sure why my PR would affect the nim tests in any way

[bjornharrtell]

This LGTM except for the comment on the nim change, @jviel-beta if you can adress that I think we can merge this (regardless of nim test failure, I think it fails due to completely unrelated reasons and we can force the merge).