Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fuzzing #1345

Merged
merged 1 commit into from Feb 16, 2024
Merged

Improve fuzzing #1345

merged 1 commit into from Feb 16, 2024

Conversation

AdamKorcz
Copy link
Contributor

This adds fuzz tests for a bunch of parsers and verification routines. The fuzzers are implemented by way of Native Go Fuzzing. They can be run by way of go test -fuzz=FuzzTest.

The PR also removes an older fuzzer.

Checklist

@AdamKorcz AdamKorcz requested a review from a team as a code owner February 3, 2024 16:38
@AdamKorcz AdamKorcz requested review from phbnf and removed request for a team February 3, 2024 16:38
Copy link
Contributor

@phbnf phbnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you very much for this!!

ctutil/fuzz_test.go Outdated Show resolved Hide resolved
@phbnf
Copy link
Contributor

phbnf commented Feb 6, 2024

@AlCutter points out that this x509 library is a fork of https://pkg.go.dev/crypto/x509, which would likely also also benefit from fuzzing if you're interested.

ctutil/fuzz_test.go Show resolved Hide resolved
ctutil/fuzz_test.go Show resolved Hide resolved
ctutil/fuzz_test.go Outdated Show resolved Hide resolved
Signed-off-by: Adam Korczynski <adam@adalogics.com>
@roger2hk roger2hk merged commit c287ad6 into google:master Feb 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants