Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: add AIX operating system #1277

Merged
merged 2 commits into from Dec 12, 2023
Merged

crypto/x509: add AIX operating system #1277

merged 2 commits into from Dec 12, 2023

Conversation

roger2hk
Copy link
Contributor

Fixes #1276. Port the AIX operating system commit changes (golang/go@29907b1) into the forked x509 package.

Checklist

@roger2hk roger2hk requested a review from a team as a code owner December 12, 2023 17:40
@roger2hk roger2hk changed the title crypto: add AIX operating system crypto/x509: add AIX operating system Dec 12, 2023
AlCutter
AlCutter approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this since it's sorta updating our fork, but I think we should look to retire these x509/asn1 package forks (at least from being publicly exported if not entirely)

@roger2hk roger2hk merged commit 1d9f7c1 into google:master Dec 12, 2023
6 checks passed
@roger2hk roger2hk deleted the goos-aix branch December 12, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCutter AlCutter AlCutter approved these changes

@mhutchinson mhutchinson Awaiting requested review from mhutchinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation Failure on GOOS=aix
2 participants
@roger2hk @AlCutter