Add conformance tests for quoted field selectors. #431
+599
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
previously approved these changes
Jan 13, 2025
jnthntatum
force-pushed
the
quoted-field-tests
branch
from
f737748 to
92ab4aa
Compare
TristonianJones
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conformance tests for quoted field selectors.
This feature adds syntax for relaxing the requirements for identifiers in field selection. The goal is to support structured keys like:
foo.`skewer-case`foo.`dotted.name`foo.`space separated`foo.`a/path`This also allows for accessing protobuf extension fields using their fully qualified name.
For now, the quoting syntax is limited to field specifiers, (either selection or message creation). Primary identifiers and function calls don't permit this yet.
Includes automated format fixes for textproto files touched.