Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static optimizers for constant folding #804

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Static optimizers for constant folding #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4552f21
Optimizer API with Constant Folding implementatiton
TristonianJones Aug 23, 2023
1db6903
Better logical folds and additional tests
TristonianJones Aug 29, 2023
0d70564
Add a configurable limit to constant folding
TristonianJones Aug 29, 2023
c15a14c
Additional comments
TristonianJones Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions cel/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ go_library(
"cel.go",
"decls.go",
"env.go",
"folding.go",
"io.go",
"library.go",
"macro.go",
"optimizer.go",
"options.go",
"program.go",
"validator.go",
Expand Down Expand Up @@ -56,6 +58,7 @@ go_test(
"cel_test.go",
"decls_test.go",
"env_test.go",
"folding_test.go",
"io_test.go",
"validator_test.go",
],
Expand Down
8 changes: 8 additions & 0 deletions cel/env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ type Ast struct {
}

// Expr returns the proto serializable instance of the parsed/checked expression.
//
// Deprecated: prefer cel.AstToCheckedExpr() or cel.AstToParsedExpr() and call GetExpr()
// the result instead.
func (ast *Ast) Expr() *exprpb.Expr {
if ast == nil {
return nil
Expand Down Expand Up @@ -221,6 +224,11 @@ func (e *Env) Check(ast *Ast) (*Ast, *Issues) {
source: ast.Source(),
impl: checked}

// Avoid creating a validator config if it's not needed.
if len(e.validators) == 0 {
return ast, nil
}

// Generate a validator configuration from the set of configured validators.
vConfig := newValidatorConfig()
for _, v := range e.validators {
Expand Down