Drop unused configPath field #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was removed during a refactor of the Google Cloud Storage SDK and is no longer needed. Since we weren't asserting types, we never got an error that we were setting a field unnecessarily.
sethvargo
force-pushed
the
sethvargo/up
branch
from
3bdb8e7
to
a35c831
Compare
verbanicm
reviewed
Dec 18, 2022
verbanicm
approved these changes
Dec 18, 2022
Merged
sethvargo
pushed a commit
that referenced
this pull request
Mar 30, 2023
## What's Changed * Clean up unit and integration tests, remove labeler by @sethvargo in #305 * Update CI and deps by @sethvargo in #306 * Drop unused configPath field by @sethvargo in #307 * Update README.md headers settable field casing by @robertvanhoesel in #312 * chore: update dependencies (automated) by @verbanicm in #315 * Print warnings when a gcloudignore is not found by @sethvargo in #313 * Switch to pull non-secret values from env by @sethvargo in #316 * Update deps by @sethvargo in #318 ## New Contributors * @robertvanhoesel made their first contribution in #312 **Full Changelog**: v1.0.0...7a972d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was removed during a refactor of the Google Cloud Storage SDK and is no longer needed. Since we weren't asserting types, we never got an error that we were setting a field unnecessarily.
Closes #254