Handle GKE Connect Gateway URL differences #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the Connect Gateway builder to always lookup the given membership and determine if the resulting cluster is a GKE cluster. If it is a GKE cluster, it uses the /gkeMemberships collection endpoint. Otherwise, it uses the standard /memberships collection endpiont. It also drops the e2e test in favor of just using kubectl directly.
sethvargo
requested review from
verbanicm,
averikitsch and
bharathkkb
and removed request for
averikitsch
sethvargo
commented
Dec 9, 2022
verbanicm
reviewed
Dec 9, 2022
verbanicm
reviewed
Dec 9, 2022
verbanicm
approved these changes
Dec 9, 2022
bharathkkb
approved these changes
Dec 9, 2022
Merged
sethvargo
pushed a commit
that referenced
this pull request
Dec 13, 2022
## What's Changed * Handle GKE Connect Gateway URL differences by @sethvargo in #258 * Update CI and deps by @sethvargo in #259 **Full Changelog**: v1.0.0...043a449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Connect Gateway builder to always lookup the given membership and determine if the resulting cluster is a GKE cluster. If it is a GKE cluster, it uses the /gkeMemberships collection endpoint. Otherwise, it uses the standard /memberships collection endpiont.
It also drops the e2e test in favor of just using kubectl directly.