Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue quota & billing requests against the provided project #191

Merged
merged 1 commit into from Dec 17, 2022
Merged

Issue quota & billing requests against the provided project #191

merged 1 commit into from Dec 17, 2022

Conversation

sethvargo
Copy link
Member

This is important for cross-project requests. If you are authenticated as project-one but set the project_id as project-two, the API quota will still be billed against the project that was authenticated, not the specified project_id. This fixes that.

@sethvargo sethvargo requested a review from a team as a code owner January 20, 2022 22:00
@sethvargo
Copy link
Member Author

Hmm interesting. I think we might need to discuss this.

@matthijsvanderloos
Copy link

I am running into this issue as well.

Also tried with gcloud and explicitly setting the billing project (gcloud container clusters get-credentials YYY --zone ZZZ --project XXX --billing-project WWW), but this results in:

ERROR: (gcloud.container.clusters.get-credentials) ResponseError: code=403, message=Caller does not have required permission to use project WWW. Grant the caller the roles/serviceusage.serviceUsageConsumer role, or a custom role with the serviceusage.services.use permission, by visiting https://console.developers.google.com/iam-admin/iam/project?project=WWW and then retry. Propagation of the new permission may take a few minutes.

So the same as in the PR checks. Is there any update?

@sethvargo sethvargo force-pushed the sethvargo/user_project branch 2 times, most recently from e654c46 to 9eea82f Compare December 10, 2022 19:58
@sethvargo sethvargo enabled auto-merge (squash) December 10, 2022 20:00
verbanicm
verbanicm reviewed Dec 15, 2022
View reviewed changes
README.md Show resolved Hide resolved
@sethvargo sethvargo merged commit 03efdc5 into main Dec 17, 2022
@sethvargo sethvargo deleted the sethvargo/user_project branch December 17, 2022 20:16
@google-github-actions-bot google-github-actions-bot mentioned this pull request May 8, 2023
Merged
verbanicm pushed a commit that referenced this pull request May 8, 2023
@google-github-actions-bot
Release: v1.0.2 (#275)
35ab0d2 
## What's Changed
* Add more debug logging and cleanup boolean inputs by @sethvargo in
#262
* Issue quota & billing requests against the provided project by
@sethvargo in
#191
* Update deps by @sethvargo in
#263
* chore: update dependencies (automated) by @verbanicm in
#266
* Switch to pull non-secret values from env by @sethvargo in
#267
* Make KUBECONFIG filename predictable by @sethvargo in
#269
* chore(deps): Bump yaml from 2.2.1 to 2.2.2 by @dependabot in
#271
* Add support info by @sethvargo in
#272
* chore: update dependencies (automated) by @verbanicm in
#274


**Full Changelog**:
v1.0.1...5ec1055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbanicm verbanicm verbanicm approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

@bharathkkb bharathkkb Awaiting requested review from bharathkkb bharathkkb is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethvargo @matthijsvanderloos @verbanicm