Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps to Node 20 #339

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Update deps to Node 20 #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ jobs:
runs-on: 'ubuntu-latest'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand All @@ -47,11 +47,11 @@ jobs:
- 'macos-latest'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down Expand Up @@ -123,11 +123,11 @@ jobs:
id-token: 'write'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down Expand Up @@ -198,11 +198,11 @@ jobs:
strategy:
fail-fast: false
steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- uses: 'actions/setup-node@v3'
- uses: 'actions/setup-node@v4'
with:
node-version: '16.x'
node-version: '20.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down
23 changes: 12 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ support](https://cloud.google.com/support).**
configure a Google Cloud Workload Identity Provider. See [setup](#setup)
for instructions.

- You must run the `actions/checkout@v3` step _before_ this action. Omitting
- You must run the `actions/checkout@v4` step _before_ this action. Omitting
the checkout step or putting it after `auth` will cause future steps to be
unable to authenticate.

Expand All @@ -50,9 +50,10 @@ support](https://cloud.google.com/support).**
gha-creds-*.json
```

- This action runs using Node 16. If you are using self-hosted GitHub Actions
runners, you must use runner version [2.285.0](https://github.com/actions/virtual-environments)
or newer.
- This action runs using Node 20. If you are using self-hosted GitHub Actions
runners, you must use a [runner
version](https://github.com/actions/virtual-environments) that supports this
version or newer.


## Usage
Expand Down Expand Up @@ -242,7 +243,7 @@ regardless of the authentication mechanism.
jobs:
job_id:
steps:
- uses: 'actions/checkout@v3' # Must come first!
- uses: 'actions/checkout@v4' # Must come first!
- uses: 'google-github-actions/auth@v1'
```

Expand Down Expand Up @@ -311,7 +312,7 @@ jobs:
id-token: 'write'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- id: 'auth'
name: 'Authenticate to Google Cloud'
Expand Down Expand Up @@ -339,7 +340,7 @@ jobs:
# ...

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- id: 'auth'
name: 'Authenticate to Google Cloud'
Expand All @@ -365,7 +366,7 @@ examples:
jobs:
job_id:
steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

- id: 'auth'
name: 'Authenticate to Google Cloud'
Expand Down Expand Up @@ -411,7 +412,7 @@ jobs:
id-token: 'write'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

# Configure Workload Identity Federation via a credentials file.
- id: 'auth'
Expand Down Expand Up @@ -455,7 +456,7 @@ jobs:
id-token: 'write'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

# Configure Workload Identity Federation and generate an access token.
- id: 'auth'
Expand Down Expand Up @@ -495,7 +496,7 @@ jobs:
id-token: 'write'

steps:
- uses: 'actions/checkout@v3'
- uses: 'actions/checkout@v4'

# Configure Workload Identity Federation and generate an access token.
- id: 'auth'
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,6 @@ branding:
color: 'blue'

runs:
using: 'node16'
using: 'node20'
main: 'dist/main/index.js'
post: 'dist/post/index.js'
4 changes: 3 additions & 1 deletion dist/main/index.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion dist/post/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/TROUBLESHOOTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ further debug:
see exactly which step is failing. Ensure you are using the latest version
of that GitHub Action.

1. Make sure you use `actions/checkout@v3` **before** the `auth` action in your
1. Make sure you use `actions/checkout@v4` **before** the `auth` action in your
workflow.

1. If the failing action is from `google-github-action/*`, please file an issue
Expand Down