Note that Firebase Admin Node.js SDK doesn't support WLIF #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
|
Is there an upstream issue tracking support we can link to? I'm not sure what "authenticate via the firebase sdk" means. |
Signed-off-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
|
@sethvargo Added a link. For context, the Firebase SDKs provide another interface to certain GCP services (Firestore, Storage, others) and Firebase projects are GCP/pantheon projects. Generally, authenticating with gcloud etc suffices for our server SDKs, but WLIF support on Node isn't there yet. firebase/firebase-admin-node#1377 |
|
Got it - thanks! I agree we should document this. |
sethvargo
approved these changes
Mar 1, 2023
This was referenced Mar 24, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
sethvargo
pushed a commit
that referenced
this pull request
Apr 17, 2023
## What's Changed * fix: update doc versions by @verbanicm in #240 * Only emit a warning if the envvar has changed by @sethvargo in #245 * Update CI and deps by @sethvargo in #248 * Document possible issues with org policies by @sethvargo in #258 * Updated troubleshooting to add permissions example by @bseib in #262 * Note that Firebase Admin Node.js SDK doesn't support WLIF by @kevinthecheung in #268 * chore: update dependencies (automated) by @verbanicm in #274 * Document admission for all repos of an owner by @djbrown in #279 * Switch to pull non-secret values from env by @sethvargo in #288 * Emit a diff of each environment variable by @sethvargo in #296 * Enable default retries of 3 retry attempts at 250ms backoff by @sethvargo in #294 ## New Contributors * @bseib made their first contribution in #262 * @kevinthecheung made their first contribution in #268 * @djbrown made their first contribution in #279 **Full Changelog**: v1.0.0...41d8fa4
ianlewis
pushed a commit
to slsa-framework/slsa-github-generator
that referenced
this pull request
Apr 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://togithub.com/actions/checkout) | action | patch | `v3.5.0` -> `v3.5.2` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | patch | `v2.2.11` -> `v2.2.12` | | [google-github-actions/auth](https://togithub.com/google-github-actions/auth) | action | minor | `v1.0.0` -> `v1.1.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/checkout</summary> ### [`v3.5.2`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v352) [Compare Source](https://togithub.com/actions/checkout/compare/v3.5.1...v3.5.2) - [Fix api endpoint for GHES](https://togithub.com/actions/checkout/pull/1289) ### [`v3.5.1`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v351) [Compare Source](https://togithub.com/actions/checkout/compare/v3.5.0...v3.5.1) - [Fix slow checkout on Windows](https://togithub.com/actions/checkout/pull/1246) </details> <details> <summary>github/codeql-action</summary> ### [`v2.2.12`](https://togithub.com/github/codeql-action/compare/v2.2.11...v2.2.12) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.2.11...v2.2.12) </details> <details> <summary>google-github-actions/auth</summary> ### [`v1.1.0`](https://togithub.com/google-github-actions/auth/releases/tag/v1.1.0) [Compare Source](https://togithub.com/google-github-actions/auth/compare/v1.0.0...v1.1.0) ##### What's Changed - fix: update doc versions by [@​verbanicm](https://togithub.com/verbanicm) in [google-github-actions/auth#240 - Only emit a warning if the envvar has changed by [@​sethvargo](https://togithub.com/sethvargo) in [google-github-actions/auth#245 - Update CI and deps by [@​sethvargo](https://togithub.com/sethvargo) in [google-github-actions/auth#248 - Document possible issues with org policies by [@​sethvargo](https://togithub.com/sethvargo) in [google-github-actions/auth#258 - Updated troubleshooting to add permissions example by [@​bseib](https://togithub.com/bseib) in [google-github-actions/auth#262 - Note that Firebase Admin Node.js SDK doesn't support WLIF by [@​kevinthecheung](https://togithub.com/kevinthecheung) in [google-github-actions/auth#268 - chore: update dependencies (automated) by [@​verbanicm](https://togithub.com/verbanicm) in [google-github-actions/auth#274 - Document admission for all repos of an owner by [@​djbrown](https://togithub.com/djbrown) in [google-github-actions/auth#279 - Switch to pull non-secret values from env by [@​sethvargo](https://togithub.com/sethvargo) in [google-github-actions/auth#288 - Emit a diff of each environment variable by [@​sethvargo](https://togithub.com/sethvargo) in [google-github-actions/auth#296 - Enable default retries of 3 retry attempts at 250ms backoff by [@​sethvargo](https://togithub.com/sethvargo) in [google-github-actions/auth#294 - Release: v1.1.0 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [google-github-actions/auth#297 ##### New Contributors - [@​bseib](https://togithub.com/bseib) made their first contribution in [google-github-actions/auth#262 - [@​kevinthecheung](https://togithub.com/kevinthecheung) made their first contribution in [google-github-actions/auth#268 - [@​djbrown](https://togithub.com/djbrown) made their first contribution in [google-github-actions/auth#279 **Full Changelog**: google-github-actions/auth@v1.0.0...v1.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/slsa-framework/slsa-github-generator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zMS40IiwidXBkYXRlZEluVmVyIjoiMzUuNDguMiJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.