RELATED: FET-769 Migrate to pure ESM #3802
Conversation
|
Merge Failed. Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator. |
2 similar comments
|
Merge Failed. Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator. |
|
Merge Failed. Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator. |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
c00950d
to
0017316
Compare
|
Merge Failed. Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator. |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
2 times, most recently
from
18d50f8
to
eb47f9a
Compare
|
Build in pipeline check aborted. |
|
Build failed (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
eb47f9a
to
9582af1
Compare
|
Build failed (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
9582af1
to
33adae6
Compare
|
Build failed (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
33adae6
to
b6b20dd
Compare
|
Build failed (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
b6b20dd
to
4dfac3a
Compare
|
Build failed (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
4dfac3a
to
2e9a164
Compare
|
Build failed (check pipeline). |
|
Build failed (check pipeline). |
|
Build failed (check pipeline). |
|
Build failed (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
c57c0b0
to
3771c01
Compare
|
Build failed (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
3771c01
to
9348508
Compare
|
Build failed (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
9348508
to
da0123d
Compare
|
Build failed (check pipeline). |
|
Merge Failed. Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator. |
|
Build failed (check pipeline). |
|
Build failed (check-extended pipeline). |
common/scripts/directory.mjs
Outdated
There was a problem hiding this comment.
We should remove this file with hardcoded path.
If we want to keep the script with extensions fix, we should make it parametrized, but I think we can remove it as well.
common/scripts/fix-ext.mjs
Outdated
There was a problem hiding this comment.
Should we remove this script? Or at least, make it parametrized?
common/scripts/fix-invariant.mjs
Outdated
There was a problem hiding this comment.
Should we remove this script? Or at least, make it parametrized?
common/scripts/fix-lodash.mjs
Outdated
There was a problem hiding this comment.
Should we remove this script? Or at least, make it parametrized?
docs/contributing.md
Outdated
| @@ -45,7 +45,7 @@ Always run `rush install`; this will make sure all the dependencies from the loc | |||
| the projects managed in the repository. After that run `rush build`. | |||
|
|
|||
| In case the pull brings in new projects or large bulk of changes, it is safer (albeit more time-consuming) to run | |||
| `rush install && rush link --force && rush clean && rush rebuild`. | |||
| `rush purge rush install && rush rebuild`. | |||
There was a problem hiding this comment.
Should it be rush clean && rush purge && rush install && rush rebuild ?
| "plugin:sonarjs/recommended", | ||
| "plugin:regexp/recommended", | ||
| "plugin:react-hooks/recommended", | ||
| "../../.eslintrc.react.js", |
There was a problem hiding this comment.
Why this removal (of react eslint extend)?
There was a problem hiding this comment.
Can we use .js or .mjs for the webpack config?
| @@ -106,24 +106,39 @@ module.exports = async (env, argv) => { | |||
| entry: ["./src/index.tsx"], | |||
| target: "web", | |||
| mode: isProduction ? "production" : "development", | |||
| experiments: { | |||
| outputModule: true, | |||
There was a problem hiding this comment.
Should we use this, as it's still experimental?
There was a problem hiding this comment.
we have no other option
| publicPath: `${basePath}/`, | ||
| library: { | ||
| type: "module", |
There was a problem hiding this comment.
Technically, playground is not a library, does this really need to be there?
There was a problem hiding this comment.
Yes its necessary
There was a problem hiding this comment.
Again, is it feasible to migrate this config to esm? (we can handle it as a followup)
|
Build in pipeline check aborted. |
Sonar scan resultMore detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR3802 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
|
Build failed (gate pipeline).
|
|
extended test - matrix-test |
|
Build failed (check-extended pipeline). |
|
extended test - matrix-test |
|
Build failed (check-extended pipeline). |
|
Build succeeded (check pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
764ac4c
to
b463f58
Compare
|
extended test - matrix-test |
|
Build failed (check-extended pipeline). |
|
extended test - matrix-test |
|
Build succeeded (check pipeline). |
|
Build succeeded (check-extended pipeline). |
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
b463f58
to
5e323cd
Compare
JIRA: FET-769
ivanmjartan
force-pushed
the
IMJ-FET-769-fin
branch
from
5e323cd
to
d34af6f
Compare
|
Build in pipeline check aborted. |
|
Build succeeded (check pipeline). |
Sonar scan resultMore detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR3802 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
|
Build succeeded (gate pipeline).
|
Supported PR commands:
ok to testextended check sonarextended test - backstopextended test - tiger-cypress - isolated <testName>extended test - tiger-cypress - record <testName>extended test - tiger-cypress - integrated <testName>extended test - cypress - isolated <testName>extended test - cypress - record <testName>extended test - cypress - integrated <testName>extended test - matrix-test <AIO_version><testName>in cypress commands is used to filter specfiles. Example, to run record with BEAR backenddashboard.spec.tsanddrilling.spec.ts, execute commandextended test - cypress - record dashboard,drillingextended test - cypress - recordorextended test - cypress - record *<AIO_version>in commands is used to start test with multiple AIO instances - each instance in triggered by one jenkins buildmasterandstable, execute commandextended test - matrix-test master,stableorextended test - matrix-test latest2.3.0and2.3.1, execute commandextended test - matrix-test 2.3.0,2.3.1<AIO_version>is empty, read versions from filecompTigerVersions.txtof this repoPR Checklist
checkpassesextended test - backstoppassesextended test - tiger-cypress - recordto record new mapping files (Tiger BE)extended test - cypress - recordto record new mapping files (Bear BE)extended test - tiger-cypress - isolatedpassesextended test - cypress - isolatedpassesextended test - tiger-cypress - integratedpassesrush changewas run if applicable