Shortcut when two json documents are same #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two json documents are same, patch is not created.
However, current code tries to check the diff and takes some time and memory.
Hence this patch adds
bytes.Equal
before creating patch to skip it.Also, the current bench mark
largeArray
is using a same valueso update it to use different values in array.
Here is the bench mark before(13a9e4a) and after (d5e5602).
large_array
becomes much faster.reflect.DeepEqual
does not make much performance degradation as percomplex
andsimple
tests.