fix old opera detection for three digit version numbers (100+) #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mucahitgurbuz
approved these changes
Aug 4, 2023
|
can confirm this PR fixes the issue, would be awesome if this got merged, so I could stop relying on using a fork in my application |
This reverts commit ccefca3.
|
Thanks for catching this! v2.2.4 is now live on npm with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Feature
Fixes mp3 playback on Opera v100+
Related Issues
#1670
Solution
The browser sniffing regex did not expect version numbers with three digits.
100got misinterpreted as10, which is less than the cut-off version33.We improve the regex.
Reproduction/Testing
You might not notice in all examples. Our application listens to
loaderror. You can add that to the radio example.Also update your Opera before testing...
Breaking Changes
N/A