Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove errcheck defaults #4734

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented May 20, 2024

The default value for ignore can be removed because errcheck.DefaultExcludedSymbols already handles those cases.

Fixes #4733

Regression related to #4709

@ldez ldez added bug Something isn't working linter: update Update the linter implementation inside golangci-lint labels May 20, 2024
@ldez ldez added this to the next milestone May 20, 2024
@ldez ldez requested a review from alexandear May 20, 2024 12:44
@ldez ldez merged commit 4beae6a into golangci:master May 20, 2024
13 checks passed
@ldez ldez deleted the fix/errcheck-default branch May 20, 2024 13:55
@ldez ldez modified the milestones: next, v1.59 May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning for option that has not been set (linters.errcheck.ignore)
2 participants