Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/denis-tingaikin/go-headerfrom 0.4.3 to 0.5.0 #4396

Merged
merged 6 commits into from Feb 25, 2024
Merged

build(deps): bump github.com/denis-tingaikin/go-headerfrom 0.4.3 to 0.5.0 #4396

merged 6 commits into from Feb 25, 2024

Conversation

firelizzard18
Copy link
Contributor

@firelizzard18 firelizzard18 commented Feb 16, 2024 •
edited by ldez

Bumps github.com/denis-tingaikin/go-header from 0.4.3 to 0.5.0.

Release notes

Sourced from github.com/denis-tingaikin/go-header's releases.

v0.5.0

What's Changed

New Contributors

Full Changelog: denis-tingaikin/go-header@v0.4.3...v0.5.0

Commits

@ldez
Copy link
Member

ldez commented Feb 16, 2024 •
edited

We will wait for an official release.

You have to know that the update of the linter is handled automatically by dependabot every Sunday (at least).
You don't need to create PR to update a linter.

This is also why we don't use pseudo version, and don't do partial update.

@ldez ldez marked this pull request as draft February 16, 2024 17:56
@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Feb 16, 2024
@ldez ldez changed the title dev: enable --fix for go-header build(deps): bump github.com/denis-tingaikin/go-headerfrom 0.4.3 to 0.5.0 Feb 16, 2024
@ldez ldez added the blocked Need's direct action from maintainer label Feb 16, 2024
ldez
ldez requested changes Feb 16, 2024
View reviewed changes
test/testshared/directives.go Show resolved Hide resolved
@firelizzard18
Copy link
Contributor Author

firelizzard18 commented Feb 16, 2024 •
edited

I did not know linter updates are handled automatically

@ldez ldez mentioned this pull request Feb 25, 2024
Closed
@ldez ldez removed the blocked Need's direct action from maintainer label Feb 25, 2024
@ldez ldez marked this pull request as ready for review February 25, 2024 16:42
ldez
ldez approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 17e736f into golangci:master Feb 25, 2024
12 checks passed
@firelizzard18 firelizzard18 deleted the go-header-fix branch February 26, 2024 01:55
@ldez ldez mentioned this pull request Mar 2, 2024
Closed
4 tasks
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@firelizzard18 @ldez @Antonboom
build(deps): bump github.com/denis-tingaikin/go-headerfrom 0.4.3 to 0…
cf7de0f 
….5.0 (golangci#4396)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
@ldez ldez added this to the next milestone Mar 4, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Milestone
v1.57
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@firelizzard18 @ldez