New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fixer #36
Implement fixer #36
Conversation
@firelizzard18 Woot! Looks good. Let me test it a bit. |
@firelizzard18 It also seems like unit tests detect SIGSEGV. https://github.com/denis-tingaikin/go-header/actions/runs/7561279933/job/21541496704?pr=36 Could you have a look? I've added an assignee to myself to get notifications; feel free to ping me inside PR when it is fixed. |
@denis-tingaikin I fixed the panic. I'm not sure why I had written
|
As I can see we have only one problem with a test. It's related to oudated input for the expected value here https://github.com/denis-tingaikin/go-header/blob/main/analyzer_test.go#L57 that we can fix with something like this: ---require.Nil(t, a.Analyze(header(`A 2000-2022 B`)))
+++require.Nil(t, a.Analyze(header(fmt.Sprintf("A 2000-%v B", time.Now().Year()))))
|
@denis-tingaikin I applied the fix for the test |
@firelizzard18 Great work! Merging.. |
Updates the analyzer to support automatic fixes for golangci-lint.
Updates #2.