fixup! linter: add perfsprint

golangci · Oct 19, 2023 · 71df6c3 · 71df6c3
1 parent ba81211
commit 71df6c3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pkg/golinters/perfsprint.go b/pkg/golinters/perfsprint.go
@@ -7,7 +7,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
 )
 
-func NewGoStrconv() *goanalysis.Linter {
+func NewPerfSprint() *goanalysis.Linter {
 	return goanalysis.NewLinter(
 		"perfsprint",
 		"Checks usages of `fmt.Sprintf` which have faster alternatives.",

diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
@@ -714,7 +714,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 
 		linter.NewConfig(golinters.NewPerfSprint()).
 			WithSince("v1.54.2").
-			WithPresets(linter.PresetStyle).
+			WithPresets(linter.PresetPerformance).
 			WithURL("https://github.com/catenacyber/perfsprint"),
 
 		linter.NewConfig(golinters.NewPreAlloc(preallocCfg)).

diff --git a/test/testdata/perfsprint.go b/test/testdata/perfsprint.go
@@ -4,5 +4,5 @@ package testdata
 import "fmt"
 
 func SprintfCouldBeStrconv() {
-	fmt.Sprintf("%d", 42) // want "Sprintf can be replaced with faster strconv.Itoa"
+	fmt.Sprintf("%d", 42) // want "fmt.Sprintf can be replaced with faster function strconv.Itoa"
 }