Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example #762

Merged
merged 1 commit into from Jun 3, 2023
Merged

docs: fix example #762

merged 1 commit into from Jun 3, 2023

Conversation

yuki0920
Copy link
Contributor

@yuki0920 yuki0920 commented Jun 3, 2023

Background

If actions/setup-go@ is before actions/checkout@v3 and go-version-file is specified in actions/setup-go, the go.mod file is not found because checkout is not done yet like this.

ScreenShot 387

So it would be easier to understand if actions/checkout@v3 is before actions/setup-go@.

If `actions/setup-go@` is before `actions/checkout@v3` and go-version-file is specified in `actions/setup-go`, the go.mod file is not found because checkout is not done yet like this.

So it would be easier to understand if `actions/checkout@v3` is before `actions/setup-go@`.
@ldez ldez changed the title fix: README.md actions/checkout@v3 order docs: fix example Jun 3, 2023
@ldez ldez added bug Something isn't working documentation Improvements or additions to documentation labels Jun 3, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez enabled auto-merge (squash) June 3, 2023 13:03
@ldez ldez merged commit b8fff06 into golangci:master Jun 3, 2023
17 checks passed
@yuki0920 yuki0920 deleted the yuki0920/fid-readme branch June 3, 2023 14:42
another-rex pushed a commit to google/osv-scanner that referenced this pull request Jun 21, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://togithub.com/actions/checkout) | action |
patch | `v3.5.2` -> `v3.5.3` |
| [docker/login-action](https://togithub.com/docker/login-action) |
action | digest | `f4ef78c` -> `465a078` |
|
[docker/setup-buildx-action](https://togithub.com/docker/setup-buildx-action)
| action | digest | `4b4e9c3` -> `ecf9528` |
|
[docker/setup-qemu-action](https://togithub.com/docker/setup-qemu-action)
| action | digest | `e81a89b` -> `2b82ce8` |
| [github/codeql-action](https://togithub.com/github/codeql-action) |
action | minor | `v2.3.6` -> `v2.20.0` |
|
[golangci/golangci-lint-action](https://togithub.com/golangci/golangci-lint-action)
| action | minor | `v3.5.0` -> `v3.6.0` |
|
[goreleaser/goreleaser-action](https://togithub.com/goreleaser/goreleaser-action)
| action | minor | `v4.2.0` -> `v4.3.0` |
|
[slsa-framework/slsa-github-generator](https://togithub.com/slsa-framework/slsa-github-generator)
| action | minor | `v1.6.0` -> `v1.7.0` |

---

### Release Notes

<details>
<summary>actions/checkout</summary>

###
[`v3.5.3`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v353)

[Compare
Source](https://togithub.com/actions/checkout/compare/v3.5.2...v3.5.3)

- [Fix: Checkout fail in self-hosted runners when faulty submodule are
checked-in](https://togithub.com/actions/checkout/pull/1196)
- [Fix typos found by
codespell](https://togithub.com/actions/checkout/pull/1287)
- [Add support for sparse
checkouts](https://togithub.com/actions/checkout/pull/1369)

</details>

<details>
<summary>github/codeql-action</summary>

###
[`v2.20.0`](https://togithub.com/github/codeql-action/compare/v2.3.6...v2.20.0)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v2.3.6...v2.20.0)

</details>

<details>
<summary>golangci/golangci-lint-action</summary>

###
[`v3.6.0`](https://togithub.com/golangci/golangci-lint-action/releases/tag/v3.6.0)

[Compare
Source](https://togithub.com/golangci/golangci-lint-action/compare/v3.5.0...v3.6.0)

#### What's Changed

- docs: fix example by [@&#8203;yuki0920](https://togithub.com/yuki0920)
in
[golangci/golangci-lint-action#762
- doc: Add custom configuration file path to args by
[@&#8203;Aisuko](https://togithub.com/Aisuko) in
[golangci/golangci-lint-action#767
- feat: add install-mode by [@&#8203;ldez](https://togithub.com/ldez) in
[golangci/golangci-lint-action#768
- feat: support out-format as args by
[@&#8203;jrehwaldt](https://togithub.com/jrehwaldt) in
[golangci/golangci-lint-action#769
- fix: out-format by [@&#8203;ldez](https://togithub.com/ldez) in
[golangci/golangci-lint-action#770

#### New Contributors

- [@&#8203;yuki0920](https://togithub.com/yuki0920) made their first
contribution in
[golangci/golangci-lint-action#762
- [@&#8203;Aisuko](https://togithub.com/Aisuko) made their first
contribution in
[golangci/golangci-lint-action#767
- [@&#8203;ldez](https://togithub.com/ldez) made their first
contribution in
[golangci/golangci-lint-action#768
- [@&#8203;jrehwaldt](https://togithub.com/jrehwaldt) made their first
contribution in
[golangci/golangci-lint-action#769

**Full Changelog**:
golangci/golangci-lint-action@v3.5.0...v3.6.0

</details>

<details>
<summary>goreleaser/goreleaser-action</summary>

###
[`v4.3.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.3.0)

[Compare
Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.2.0...v4.3.0)

#### What's Changed

- Update in command examples by
[@&#8203;arnaduga](https://togithub.com/arnaduga) in
[goreleaser/goreleaser-action#393
- chore(deps): bump yargs from 17.6.2 to 17.7.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[goreleaser/goreleaser-action#395
- Improve documentation for use of `GITHUB_TOKEN` by
[@&#8203;jamietanna](https://togithub.com/jamietanna) in
[goreleaser/goreleaser-action#399
- chore(deps): bump actions/setup-go from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[goreleaser/goreleaser-action#403
- chore(deps): bump docker/bake-action from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[goreleaser/goreleaser-action#408
- chore(deps): bump semver from 7.3.8 to 7.5.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[goreleaser/goreleaser-action#407
- Bump setup-go action version to v4 in README by
[@&#8203;kishaningithub](https://togithub.com/kishaningithub) in
[goreleaser/goreleaser-action#411
- ci: split test and validate workflow by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[goreleaser/goreleaser-action#413
- chore: update yarn to 3.5.1 by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[goreleaser/goreleaser-action#412
- chore(deps): bump yargs from 17.7.1 to 17.7.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[goreleaser/goreleaser-action#410
- feat: support nightly by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[goreleaser/goreleaser-action#419

#### New Contributors

- [@&#8203;arnaduga](https://togithub.com/arnaduga) made their first
contribution in
[goreleaser/goreleaser-action#393
- [@&#8203;jamietanna](https://togithub.com/jamietanna) made their first
contribution in
[goreleaser/goreleaser-action#399
- [@&#8203;kishaningithub](https://togithub.com/kishaningithub) made
their first contribution in
[goreleaser/goreleaser-action#411

**Full Changelog**:
goreleaser/goreleaser-action@v4.2.0...v4.3.0

</details>

<details>
<summary>slsa-framework/slsa-github-generator</summary>

###
[`v1.7.0`](https://togithub.com/slsa-framework/slsa-github-generator/releases/tag/v1.7.0)

[Compare
Source](https://togithub.com/slsa-framework/slsa-github-generator/compare/v1.6.0...v1.7.0)

See the [CHANGELOG](./CHANGELOG.md) for details.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on monday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/google/osv-scanner).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Aug 1, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| booxmedialtd/ws-action-parse-semver | action | digest | `966a265` -> `7784200` |
| [docker.elastic.co/elasticsearch/elasticsearch](https://togithub.com/elastic/elasticsearch) | service | minor | `8.7.0` -> `8.9.0` |
| getmeili/meilisearch | service | minor | `v1.1.0` -> `v1.3.0` |
| [golangci/golangci-lint-action](https://togithub.com/golangci/golangci-lint-action) | action | minor | `v3.4.0` -> `v3.6.0` |
| mtlynch/firestore-emulator | service | digest | `327f3c8` -> `74dc4be` |
| peter-evans/create-or-update-comment | action | digest | `5f728c3` -> `716151b` |
| peter-evans/find-comment | action | digest | `ebedc73` -> `5cea877` |
| tinkerpop/gremlin-server | service | patch | `3.6.2` -> `3.6.4` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>elastic/elasticsearch (docker.elastic.co/elasticsearch/elasticsearch)</summary>

### [`v8.9.0`](https://togithub.com/elastic/elasticsearch/releases/tag/v8.9.0): Elasticsearch 8.9.0

[Compare Source](https://togithub.com/elastic/elasticsearch/compare/v8.8.2...v8.9.0)

Downloads: https://elastic.co/downloads/elasticsearch
Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/8.9/release-notes-8.9.0.html

### [`v8.8.2`](https://togithub.com/elastic/elasticsearch/releases/tag/v8.8.2): Elasticsearch 8.8.2

[Compare Source](https://togithub.com/elastic/elasticsearch/compare/v8.8.1...v8.8.2)

Downloads: https://elastic.co/downloads/elasticsearch
Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/8.8/release-notes-8.8.2.html

### [`v8.8.1`](https://togithub.com/elastic/elasticsearch/releases/tag/v8.8.1): Elasticsearch 8.8.1

[Compare Source](https://togithub.com/elastic/elasticsearch/compare/v8.8.0...v8.8.1)

Downloads: https://elastic.co/downloads/elasticsearch
Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/8.8/release-notes-8.8.1.html

### [`v8.8.0`](https://togithub.com/elastic/elasticsearch/releases/tag/v8.8.0): Elasticsearch 8.8.0

[Compare Source](https://togithub.com/elastic/elasticsearch/compare/v8.7.1...v8.8.0)

Downloads: https://elastic.co/downloads/elasticsearch
Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/8.8/release-notes-8.8.0.html

### [`v8.7.1`](https://togithub.com/elastic/elasticsearch/releases/tag/v8.7.1): Elasticsearch 8.7.1

[Compare Source](https://togithub.com/elastic/elasticsearch/compare/v8.7.0...v8.7.1)

Downloads: https://elastic.co/downloads/elasticsearch
Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/8.7/release-notes-8.7.1.html

</details>

<details>
<summary>golangci/golangci-lint-action (golangci/golangci-lint-action)</summary>

### [`v3.6.0`](https://togithub.com/golangci/golangci-lint-action/releases/tag/v3.6.0)

[Compare Source](https://togithub.com/golangci/golangci-lint-action/compare/v3.5.0...v3.6.0)

#### What's Changed

-   docs: fix example by [@&#8203;yuki0920](https://togithub.com/yuki0920) in [golangci/golangci-lint-action#762
-   doc: Add custom configuration file path to args by [@&#8203;Aisuko](https://togithub.com/Aisuko) in [golangci/golangci-lint-action#767
-   feat: add install-mode by [@&#8203;ldez](https://togithub.com/ldez) in [golangci/golangci-lint-action#768
-   feat: support out-format as args by [@&#8203;jrehwaldt](https://togithub.com/jrehwaldt) in [golangci/golangci-lint-action#769
-   fix: out-format by [@&#8203;ldez](https://togithub.com/ldez) in [golangci/golangci-lint-action#770

#### New Contributors

-   [@&#8203;yuki0920](https://togithub.com/yuki0920) made their first contribution in [golangci/golangci-lint-action#762
-   [@&#8203;Aisuko](https://togithub.com/Aisuko) made their first contribution in [golangci/golangci-lint-action#767
-   [@&#8203;ldez](https://togithub.com/ldez) made their first contribution in [golangci/golangci-lint-action#768
-   [@&#8203;jrehwaldt](https://togithub.com/jrehwaldt) made their first contribution in [golangci/golangci-lint-action#769

**Full Changelog**: golangci/golangci-lint-action@v3.5.0...v3.6.0

### [`v3.5.0`](https://togithub.com/golangci/golangci-lint-action/releases/tag/v3.5.0)

[Compare Source](https://togithub.com/golangci/golangci-lint-action/compare/v3.4.0...v3.5.0)

#### What's Changed

-   doc: add quote around go version by [@&#8203;vaughany](https://togithub.com/vaughany) in [golangci/golangci-lint-action#670
-   docs/build: update to setup-go@v4 by [@&#8203;caarlos0](https://togithub.com/caarlos0) in [golangci/golangci-lint-action#704
-   fix invalid docs about cache key by [@&#8203;hori-ryota](https://togithub.com/hori-ryota) in [golangci/golangci-lint-action#695

#### New Contributors

-   [@&#8203;vaughany](https://togithub.com/vaughany) made their first contribution in [golangci/golangci-lint-action#670
-   [@&#8203;caarlos0](https://togithub.com/caarlos0) made their first contribution in [golangci/golangci-lint-action#704
-   [@&#8203;hori-ryota](https://togithub.com/hori-ryota) made their first contribution in [golangci/golangci-lint-action#695

**Full Changelog**: golangci/golangci-lint-action@v3.4.0...v3.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
@renovate renovate bot mentioned this pull request Feb 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants