Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension/package.json: edit default launch package dir #3388

Closed
wants to merge 1 commit into from
Closed

extension/package.json: edit default launch package dir #3388

wants to merge 1 commit into from
+1 −1

Conversation

yimiaoxiehou
Copy link
Contributor

@yimiaoxiehou yimiaoxiehou commented May 14, 2024 •
edited by hyangah

Edit .vscode/launch.json Go: Launch package template from "program": "^\"\\${fileDirname}${1:}\"" to "program": "^\"\\${workspaceFolder}${1:}\""

Fixes #3387

@google-cla Google CLA
Copy link

google-cla bot commented May 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yimiaoxiehou yimiaoxiehou mentioned this pull request May 14, 2024
Closed
@gopherbot
Copy link
Collaborator

This PR (HEAD: bb71b75) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/585615.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 81d43b8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/585615.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

This PR (HEAD: d8df56c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/585615.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from 一秒yimiao:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@suzmue suzmue changed the title eidt default launch package dir extension/package.json: edit default launch package dir May 30, 2024
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 4: Code-Review+1 Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 5: Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 5:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/203db02f-97fc-41a5-b5d8-8896ca460587

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/203db02f-97fc-41a5-b5d8-8896ca460587

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 5: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/203db02f-97fc-41a5-b5d8-8896ca460587

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 6:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/cf337f0d-17bd-421d-a124-6f8256b156e5

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 6:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/cf337f0d-17bd-421d-a124-6f8256b156e5

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 6: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/cf337f0d-17bd-421d-a124-6f8256b156e5

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 7: Auto-Submit+1 Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 7:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/a8fceb42-aef4-4d62-b85b-d3cae3ea46ce

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 7:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/a8fceb42-aef4-4d62-b85b-d3cae3ea46ce

Please don’t reply on this GitHub thread. Visit golang.org/cl/585615.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 30, 2024
@yimiaoxiehou @gopherbot
extension/package.json: edit default launch package dir
540e146 
Edit .vscode/launch.json `Go: Launch package` template from `"program": "^\"\\${fileDirname}${1:}\""` to `"program": "^\"\\${workspaceFolder}${1:}\""`

Fixes #3387

Change-Id: I35af5ebe551830c2b99c62c652e6ad7309a0527b
GitHub-Last-Rev: d8df56c
GitHub-Pull-Request: #3388
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/585615
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/585615 has been merged.

@gopherbot gopherbot closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

edit default .vscode/launch.js "Launch Package" program work dir
2 participants
@yimiaoxiehou @gopherbot