Skip to content

Commit

Permalink
.github/workflows: partially revert go.dev/cl/380175
Browse files Browse the repository at this point in the history
Splitting into build + release jobs doesn't work as I thought.
Cloned repository state isn't shared between jobs obviously.
We should've built the artifact (.vsix) from the build stage,
pass the artifact location to the publish stage. But more
investigation work is necessary.

To unblock nightly release, revert the change.

The only remaining change from go.dev/cl/380175 is to switch
from repository_dispatch to workflow_dispatch, and
use of the Nightly environment.

Change-Id: I11bd655b875208c6001afd9fe03e511d0396d573
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/381574
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
  • Loading branch information
hyangah committed Jan 28, 2022
1 parent 59d4c16 commit 0a9d740
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions .github/workflows/release-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ on:
workflow_dispatch:

jobs:
build:
if: github.ref == 'refs/heads/master'
release:
if: github.ref == 'refs/heads/master' && github.repository == 'golang/vscode-go'

name: Build Nightly
name: Release Nightly
runs-on: ubuntu-latest
environment: nightly
timeout-minutes: 20

steps:
Expand Down Expand Up @@ -58,14 +59,8 @@ jobs:
CODE_VERSION: 'insiders'
VSCODEGO_BEFORE_RELEASE_TESTS: true

publish:
if: github.ref == 'refs/heads/master' && github.repository == 'golang/vscode-go'

needs: [build]
runs-on: ubuntu-latest
environment: nightly
steps:
- name: Publish
if: github.ref == 'refs/heads/master' && github.repository == 'golang/vscode-go'
uses: lannonbr/vsce-action@0f3391ee0477b08fae949eb0a875e91e6d20b075
with:
args: "publish -p $VSCE_TOKEN"
Expand Down

0 comments on commit 0a9d740

Please sign in to comment.