Add ReadByte method, satisfies the io.ByteReader interface #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all.
In this PR I've added a ReadByte method to Reader in order to implement the io.ByteReader interface. The reasoning is that snappy's reader is already buffered, and needing to wrap it with a bufio.Reader instance in order to, say, directly decode varints leads to extra copying and complication.
I've tried to add as little code as possible, and the only notable change to the code of Reader was to move the buffer-filling loop from the Read method to a bufio-style fill method. The test is a modified version of the test for a buffered Writer, but covers the use case of encoding the length of entries as varints.
Thanks!