-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os/exec: on Windows look for extensions in Run if not already done #67035
Open
qiulaidongfeng
wants to merge
13
commits into
golang:master
Choose a base branch
from
qiulaidongfeng:66586
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−6
Commits on May 30, 2024
-
os/exec: not add a suffix to Cmd.Path
For avoid data race for cmd.Path , in CL 527820 fixed data race , but addition of suffixe as shown in golang#66586 was also introduced. The result of call lookExtensions is actually the name passed to os.StartProcess, But solutions at the time chose to reuse cmd.Path to represent the name passed to os.StartProcess,since this results in golang#66586, So use new field save call lookExtensions result. Fixes golang#66586 Change-Id: Ib1baa6d7803f9471af6e38bcb55f0298422e6743
Configuration menu - View commit details
-
Copy full SHA for f51931d - Browse repository at this point
Copy the full SHA f51931dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 078683c - Browse repository at this point
Copy the full SHA 078683cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff7b0a6 - Browse repository at this point
Copy the full SHA ff7b0a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73f07ac - Browse repository at this point
Copy the full SHA 73f07acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ba34d5 - Browse repository at this point
Copy the full SHA 7ba34d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b41c326 - Browse repository at this point
Copy the full SHA b41c326View commit details -
Configuration menu - View commit details
-
Copy full SHA for d82fe30 - Browse repository at this point
Copy the full SHA d82fe30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44f0084 - Browse repository at this point
Copy the full SHA 44f0084View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9ace65 - Browse repository at this point
Copy the full SHA f9ace65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee45f8 - Browse repository at this point
Copy the full SHA 7ee45f8View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 197d6e4 - Browse repository at this point
Copy the full SHA 197d6e4View commit details
Commits on Jun 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b7431d6 - Browse repository at this point
Copy the full SHA b7431d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc3169f - Browse repository at this point
Copy the full SHA dc3169fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.