Fix jwt -show #406
Merged
Fix jwt -show #406
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago (was lazy to dig history) jwt.Parse was changed to require non-nil keyFunc. This broke `jwt -show` command that prints header and claims and does not validate the token: ``` $ echo $TOKEN | jwt -show - Error: malformed token: token is unverifiable: no keyfunc was provided ``` This change fixes `jwt -show`.
|
Sounds reasonably to me. Can we somehow add a little more documentation to the to itself that the token is only displayed but not verified? |
oxisto
approved these changes
Aug 29, 2024
|
I've updated usage texts. |
mfridman
approved these changes
Sep 6, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 22, 2025
…/forgejo) (#7297) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/golang-jwt/jwt/v5](https://github.com/golang-jwt/jwt) | require | patch | `v5.2.0` -> `v5.2.2` | --- ### jwt-go allows excessive memory allocation during header parsing [CVE-2025-30204](https://nvd.nist.gov/vuln/detail/CVE-2025-30204) / [GHSA-mh63-6h87-95cp](GHSA-mh63-6h87-95cp) <details> <summary>More information</summary> #### Details ##### Summary Function [`parse.ParseUnverified`](https://github.com/golang-jwt/jwt/blob/c035977d9e11c351f4c05dfeae193923cbab49ee/parser.go#L138-L139) currently splits (via a call to [strings.Split](https://pkg.go.dev/strings#Split)) its argument (which is untrusted data) on periods. As a result, in the face of a malicious request whose _Authorization_ header consists of `Bearer ` followed by many period characters, a call to that function incurs allocations to the tune of O(n) bytes (where n stands for the length of the function's argument), with a constant factor of about 16. Relevant weakness: [CWE-405: Asymmetric Resource Consumption (Amplification)](https://cwe.mitre.org/data/definitions/405.html) ##### Details See [`parse.ParseUnverified`](https://github.com/golang-jwt/jwt/blob/c035977d9e11c351f4c05dfeae193923cbab49ee/parser.go#L138-L139) ##### Impact Excessive memory allocation #### Severity - CVSS Score: 7.5 / 10 (High) - Vector String: `CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H` #### References - [https://github.com/golang-jwt/jwt/security/advisories/GHSA-mh63-6h87-95cp](https://github.com/golang-jwt/jwt/security/advisories/GHSA-mh63-6h87-95cp) - [https://github.com/golang-jwt/jwt/commit/0951d184286dece21f73c85673fd308786ffe9c3](https://github.com/golang-jwt/jwt/commit/0951d184286dece21f73c85673fd308786ffe9c3) - [https://github.com/golang-jwt/jwt](https://github.com/golang-jwt/jwt) This data is provided by [OSV](https://osv.dev/vulnerability/GHSA-mh63-6h87-95cp) and the [GitHub Advisory Database](https://github.com/github/advisory-database) ([CC-BY 4.0](https://github.com/github/advisory-database/blob/main/LICENSE.md)). </details> --- ### Release Notes <details> <summary>golang-jwt/jwt (github.com/golang-jwt/jwt/v5)</summary> ### [`v5.2.2`](https://github.com/golang-jwt/jwt/releases/tag/v5.2.2) [Compare Source](golang-jwt/jwt@v5.2.1...v5.2.2) #### What's Changed - Fixed GHSA-mh63-6h87-95cp by [@​mfridman](https://github.com/mfridman) - Fixed some typos by [@​Ashikpaul](https://github.com/Ashikpaul) in golang-jwt/jwt#382 - build: add go1.22 to ci workflows by [@​mfridman](https://github.com/mfridman) in golang-jwt/jwt#383 - Bump golangci/golangci-lint-action from 4 to 5 by [@​dependabot](https://github.com/dependabot) in golang-jwt/jwt#387 - Bump golangci/golangci-lint-action from 5 to 6 by [@​dependabot](https://github.com/dependabot) in golang-jwt/jwt#389 - chore: bump ci tests to include go1.23 by [@​mfridman](https://github.com/mfridman) in golang-jwt/jwt#405 - Fix jwt -show by [@​AlexanderYastrebov](https://github.com/AlexanderYastrebov) in golang-jwt/jwt#406 - docs: typo by [@​kvii](https://github.com/kvii) in golang-jwt/jwt#407 - Update SECURITY.md by [@​oxisto](https://github.com/oxisto) in golang-jwt/jwt#416 - Update `jwt.Parse` example to use `jwt.WithValidMethods` by [@​mattt](https://github.com/mattt) in golang-jwt/jwt#425 #### New Contributors - [@​Ashikpaul](https://github.com/Ashikpaul) made their first contribution in golang-jwt/jwt#382 - [@​kvii](https://github.com/kvii) made their first contribution in golang-jwt/jwt#407 - [@​mattt](https://github.com/mattt) made their first contribution in golang-jwt/jwt#425 **Full Changelog**: golang-jwt/jwt@v5.2.1...v5.2.2 ### [`v5.2.1`](https://github.com/golang-jwt/jwt/releases/tag/v5.2.1) [Compare Source](golang-jwt/jwt@v5.2.0...v5.2.1) #### What's Changed - chore: remove unnecessary conversions from tests by [@​estensen](https://github.com/estensen) in golang-jwt/jwt#370 - Trivial: Typo fix for ECDSA error message by [@​tjs-cinemo](https://github.com/tjs-cinemo) in golang-jwt/jwt#373 - Fix incorrect error return by [@​ss49919201](https://github.com/ss49919201) in golang-jwt/jwt#371 #### New Contributors - [@​tjs-cinemo](https://github.com/tjs-cinemo) made their first contribution in golang-jwt/jwt#373 - [@​ss49919201](https://github.com/ss49919201) made their first contribution in golang-jwt/jwt#371 **Full Changelog**: golang-jwt/jwt@v5.2.0...v5.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNS4xIiwidGFyZ2V0QnJhbmNoIjoidjcuMC9mb3JnZWpvIiwibGFiZWxzIjpbImRlcGVuZGVuY3ktdXBncmFkZSIsInRlc3Qvbm90LW5lZWRlZCJdfQ==--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7297 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 22, 2025
…0/forgejo) (#7302) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/golang-jwt/jwt/v5](https://github.com/golang-jwt/jwt) | require | patch | `v5.2.1` -> `v5.2.2` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### jwt-go allows excessive memory allocation during header parsing [CVE-2025-30204](https://nvd.nist.gov/vuln/detail/CVE-2025-30204) / [GHSA-mh63-6h87-95cp](GHSA-mh63-6h87-95cp) <details> <summary>More information</summary> #### Details ##### Summary Function [`parse.ParseUnverified`](https://github.com/golang-jwt/jwt/blob/c035977d9e11c351f4c05dfeae193923cbab49ee/parser.go#L138-L139) currently splits (via a call to [strings.Split](https://pkg.go.dev/strings#Split)) its argument (which is untrusted data) on periods. As a result, in the face of a malicious request whose _Authorization_ header consists of `Bearer ` followed by many period characters, a call to that function incurs allocations to the tune of O(n) bytes (where n stands for the length of the function's argument), with a constant factor of about 16. Relevant weakness: [CWE-405: Asymmetric Resource Consumption (Amplification)](https://cwe.mitre.org/data/definitions/405.html) ##### Details See [`parse.ParseUnverified`](https://github.com/golang-jwt/jwt/blob/c035977d9e11c351f4c05dfeae193923cbab49ee/parser.go#L138-L139) ##### Impact Excessive memory allocation #### Severity - CVSS Score: 7.5 / 10 (High) - Vector String: `CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H` #### References - [https://github.com/golang-jwt/jwt/security/advisories/GHSA-mh63-6h87-95cp](https://github.com/golang-jwt/jwt/security/advisories/GHSA-mh63-6h87-95cp) - [https://github.com/golang-jwt/jwt/commit/0951d184286dece21f73c85673fd308786ffe9c3](https://github.com/golang-jwt/jwt/commit/0951d184286dece21f73c85673fd308786ffe9c3) - [https://github.com/golang-jwt/jwt](https://github.com/golang-jwt/jwt) This data is provided by [OSV](https://osv.dev/vulnerability/GHSA-mh63-6h87-95cp) and the [GitHub Advisory Database](https://github.com/github/advisory-database) ([CC-BY 4.0](https://github.com/github/advisory-database/blob/main/LICENSE.md)). </details> --- ### Release Notes <details> <summary>golang-jwt/jwt (github.com/golang-jwt/jwt/v5)</summary> ### [`v5.2.2`](https://github.com/golang-jwt/jwt/releases/tag/v5.2.2) [Compare Source](golang-jwt/jwt@v5.2.1...v5.2.2) #### What's Changed - Fixed GHSA-mh63-6h87-95cp by [@​mfridman](https://github.com/mfridman) - Fixed some typos by [@​Ashikpaul](https://github.com/Ashikpaul) in golang-jwt/jwt#382 - build: add go1.22 to ci workflows by [@​mfridman](https://github.com/mfridman) in golang-jwt/jwt#383 - Bump golangci/golangci-lint-action from 4 to 5 by [@​dependabot](https://github.com/dependabot) in golang-jwt/jwt#387 - Bump golangci/golangci-lint-action from 5 to 6 by [@​dependabot](https://github.com/dependabot) in golang-jwt/jwt#389 - chore: bump ci tests to include go1.23 by [@​mfridman](https://github.com/mfridman) in golang-jwt/jwt#405 - Fix jwt -show by [@​AlexanderYastrebov](https://github.com/AlexanderYastrebov) in golang-jwt/jwt#406 - docs: typo by [@​kvii](https://github.com/kvii) in golang-jwt/jwt#407 - Update SECURITY.md by [@​oxisto](https://github.com/oxisto) in golang-jwt/jwt#416 - Update `jwt.Parse` example to use `jwt.WithValidMethods` by [@​mattt](https://github.com/mattt) in golang-jwt/jwt#425 #### New Contributors - [@​Ashikpaul](https://github.com/Ashikpaul) made their first contribution in golang-jwt/jwt#382 - [@​kvii](https://github.com/kvii) made their first contribution in golang-jwt/jwt#407 - [@​mattt](https://github.com/mattt) made their first contribution in golang-jwt/jwt#425 **Full Changelog**: golang-jwt/jwt@v5.2.1...v5.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNS4xIiwidGFyZ2V0QnJhbmNoIjoidjEwLjAvZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7302 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 22, 2025
…ejo) (#7296) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/golang-jwt/jwt/v5](https://github.com/golang-jwt/jwt) | require | patch | `v5.2.1` -> `v5.2.2` | --- ### jwt-go allows excessive memory allocation during header parsing [CVE-2025-30204](https://nvd.nist.gov/vuln/detail/CVE-2025-30204) / [GHSA-mh63-6h87-95cp](GHSA-mh63-6h87-95cp) <details> <summary>More information</summary> #### Details ##### Summary Function [`parse.ParseUnverified`](https://github.com/golang-jwt/jwt/blob/c035977d9e11c351f4c05dfeae193923cbab49ee/parser.go#L138-L139) currently splits (via a call to [strings.Split](https://pkg.go.dev/strings#Split)) its argument (which is untrusted data) on periods. As a result, in the face of a malicious request whose _Authorization_ header consists of `Bearer ` followed by many period characters, a call to that function incurs allocations to the tune of O(n) bytes (where n stands for the length of the function's argument), with a constant factor of about 16. Relevant weakness: [CWE-405: Asymmetric Resource Consumption (Amplification)](https://cwe.mitre.org/data/definitions/405.html) ##### Details See [`parse.ParseUnverified`](https://github.com/golang-jwt/jwt/blob/c035977d9e11c351f4c05dfeae193923cbab49ee/parser.go#L138-L139) ##### Impact Excessive memory allocation #### Severity - CVSS Score: 7.5 / 10 (High) - Vector String: `CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H` #### References - [https://github.com/golang-jwt/jwt/security/advisories/GHSA-mh63-6h87-95cp](https://github.com/golang-jwt/jwt/security/advisories/GHSA-mh63-6h87-95cp) - [https://github.com/golang-jwt/jwt/commit/0951d184286dece21f73c85673fd308786ffe9c3](https://github.com/golang-jwt/jwt/commit/0951d184286dece21f73c85673fd308786ffe9c3) - [https://github.com/golang-jwt/jwt](https://github.com/golang-jwt/jwt) This data is provided by [OSV](https://osv.dev/vulnerability/GHSA-mh63-6h87-95cp) and the [GitHub Advisory Database](https://github.com/github/advisory-database) ([CC-BY 4.0](https://github.com/github/advisory-database/blob/main/LICENSE.md)). </details> --- ### Release Notes <details> <summary>golang-jwt/jwt (github.com/golang-jwt/jwt/v5)</summary> ### [`v5.2.2`](https://github.com/golang-jwt/jwt/releases/tag/v5.2.2) [Compare Source](golang-jwt/jwt@v5.2.1...v5.2.2) #### What's Changed - Fixed GHSA-mh63-6h87-95cp by [@​mfridman](https://github.com/mfridman) - Fixed some typos by [@​Ashikpaul](https://github.com/Ashikpaul) in golang-jwt/jwt#382 - build: add go1.22 to ci workflows by [@​mfridman](https://github.com/mfridman) in golang-jwt/jwt#383 - Bump golangci/golangci-lint-action from 4 to 5 by [@​dependabot](https://github.com/dependabot) in golang-jwt/jwt#387 - Bump golangci/golangci-lint-action from 5 to 6 by [@​dependabot](https://github.com/dependabot) in golang-jwt/jwt#389 - chore: bump ci tests to include go1.23 by [@​mfridman](https://github.com/mfridman) in golang-jwt/jwt#405 - Fix jwt -show by [@​AlexanderYastrebov](https://github.com/AlexanderYastrebov) in golang-jwt/jwt#406 - docs: typo by [@​kvii](https://github.com/kvii) in golang-jwt/jwt#407 - Update SECURITY.md by [@​oxisto](https://github.com/oxisto) in golang-jwt/jwt#416 - Update `jwt.Parse` example to use `jwt.WithValidMethods` by [@​mattt](https://github.com/mattt) in golang-jwt/jwt#425 #### New Contributors - [@​Ashikpaul](https://github.com/Ashikpaul) made their first contribution in golang-jwt/jwt#382 - [@​kvii](https://github.com/kvii) made their first contribution in golang-jwt/jwt#407 - [@​mattt](https://github.com/mattt) made their first contribution in golang-jwt/jwt#425 **Full Changelog**: golang-jwt/jwt@v5.2.1...v5.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMDUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjIwNS4xIiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7296 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago (was lazy to dig history) jwt.Parse was changed to require non-nil keyFunc.
This broke
jwt -showcommand that prints header and claims and does not validate the token:This change fixes
jwt -show.